[NaCl SDK] Refactor STATUSCODE_*

[NaCl SDK] Refactor STATUSCODE_*

Move "STATUSCODE_OK, STATUSCODE_PARTIAL_CONTENT, STATUSCODE_FORBIDDEN,
STATUSCODE_NOT_FOUND, STATUSCODE_REQUESTED_RANGE_NOT_SATISFIABLE' from
http_fs_node.cc to http_status_codes.h to share the codes with the
future functionalities exposed to nacl_io.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Committed: https://crrev.com/1001cfaab4de5b1fdbc776908cc4113bc953a741
Cr-Commit-Position: refs/heads/master@{#433413}

[chanpatorikku, 2016-11-18 17:21:55]

Description was changed from

==========
[NaCl SDK] Refactor STATUSCODE_*

Move "STATUSCODE_OK, STATUSCODE_PARTIAL_CONTENT, STATUSCODE_FORBIDDEN,
STATUSCODE_NOT_FOUND, STATUSCODE_REQUESTED_RANGE_NOT_SATISFIABLE' from
http_fs_node.cc to statuscode.h to share the codes with the future
functionalities exposed to nacl_io.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Refactor STATUSCODE_*

Move "STATUSCODE_OK, STATUSCODE_PARTIAL_CONTENT, STATUSCODE_FORBIDDEN,
STATUSCODE_NOT_FOUND, STATUSCODE_REQUESTED_RANGE_NOT_SATISFIABLE' from
http_fs_node.cc to statuscode.h to share the codes with the future
functionalities exposed to nacl_io.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[chanpatorikku, 2016-11-18 17:21:55]

chanpatorikku@gmail.com changed reviewers:
+ binji@chromium.org, sbc@chromium.org

[chanpatorikku, 2016-11-18 17:22:19]

ptal

[Sam Clegg, 2016-11-18 17:32:30]

lgtm % comments

https://codereview.chromium.org/2518593002/diff/1/native_client_sdk/src/libra...
File native_client_sdk/src/libraries/nacl_io/statuscode.h (right):

https://codereview.chromium.org/2518593002/diff/1/native_client_sdk/src/libra...
native_client_sdk/src/libraries/nacl_io/statuscode.h:1: // Copyright (c) 2016
The Chromium Authors. All rights reserved.
New files don't need the (c) here

https://codereview.chromium.org/2518593002/diff/1/native_client_sdk/src/libra...
native_client_sdk/src/libraries/nacl_io/statuscode.h:14: const int32_t
STATUSCODE_REQUESTED_RANGE_NOT_SATISFIABLE = 416;
Perhaps call this file http_status_codes.h?

[chanpatorikku, 2016-11-19 06:22:55]

Patchset #2 (id:20001) has been deleted

[chanpatorikku, 2016-11-19 06:31:26]

Description was changed from

==========
[NaCl SDK] Refactor STATUSCODE_*

Move "STATUSCODE_OK, STATUSCODE_PARTIAL_CONTENT, STATUSCODE_FORBIDDEN,
STATUSCODE_NOT_FOUND, STATUSCODE_REQUESTED_RANGE_NOT_SATISFIABLE' from
http_fs_node.cc to statuscode.h to share the codes with the future
functionalities exposed to nacl_io.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Refactor STATUSCODE_*

Move "STATUSCODE_OK, STATUSCODE_PARTIAL_CONTENT, STATUSCODE_FORBIDDEN,
STATUSCODE_NOT_FOUND, STATUSCODE_REQUESTED_RANGE_NOT_SATISFIABLE' from
http_fs_node.cc to http_status_codes.h to share the codes with the 
future functionalities exposed to nacl_io.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

[chanpatorikku, 2016-11-19 06:33:23]

The CQ bit was checked by chanpatorikku@gmail.com

[chanpatorikku, 2016-11-19 06:33:24]

The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org
Link to the patchset: https://codereview.chromium.org/2518593002/#ps40001
(title: "")

[commit-bot: I haz the power, 2016-11-19 06:33:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 08:32:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 08:32:22]

Failed to apply patch for
native_client_sdk/src/libraries/nacl_io/http_status_codes.h:
While running git apply --index -p1;
  error: native_client_sdk/src/libraries/nacl_io/http_status_codes.h: already
exists in index

Patch:   N   native_client_sdk/src/libraries/nacl_io/http_status_codes.h
Index: native_client_sdk/src/libraries/nacl_io/http_status_codes.h
diff --git a/native_client_sdk/src/libraries/nacl_io/http_status_codes.h
b/native_client_sdk/src/libraries/nacl_io/http_status_codes.h
new file mode 100644
index
0000000000000000000000000000000000000000..9425e721e4c5ffc59768881a153fa842569c3364
--- /dev/null
+++ b/native_client_sdk/src/libraries/nacl_io/http_status_codes.h
@@ -0,0 +1,18 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef LIBRARIES_NACL_IO_HTTP_STATUS_CODES_H_
+#define LIBRARIES_NACL_IO_HTTP_STATUS_CODES_H_
+
+namespace nacl_io {
+
+const int32_t STATUSCODE_OK = 200;
+const int32_t STATUSCODE_PARTIAL_CONTENT = 206;
+const int32_t STATUSCODE_FORBIDDEN = 403;
+const int32_t STATUSCODE_NOT_FOUND = 404;
+const int32_t STATUSCODE_REQUESTED_RANGE_NOT_SATISFIABLE = 416;
+
+}  // namespace nacl_io
+
+#endif  // LIBRARIES_NACL_IO_HTTP_STATUS_CODES_H_

[commit-bot: I haz the power, 2016-11-19 08:39:06]

Description was changed from

==========
[NaCl SDK] Refactor STATUSCODE_*

Move "STATUSCODE_OK, STATUSCODE_PARTIAL_CONTENT, STATUSCODE_FORBIDDEN,
STATUSCODE_NOT_FOUND, STATUSCODE_REQUESTED_RANGE_NOT_SATISFIABLE' from
http_fs_node.cc to http_status_codes.h to share the codes with the 
future functionalities exposed to nacl_io.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk
==========

to

==========
[NaCl SDK] Refactor STATUSCODE_*

Move "STATUSCODE_OK, STATUSCODE_PARTIAL_CONTENT, STATUSCODE_FORBIDDEN,
STATUSCODE_NOT_FOUND, STATUSCODE_REQUESTED_RANGE_NOT_SATISFIABLE' from
http_fs_node.cc to http_status_codes.h to share the codes with the
future functionalities exposed to nacl_io.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk

Committed: https://crrev.com/1001cfaab4de5b1fdbc776908cc4113bc953a741
Cr-Commit-Position: refs/heads/master@{#433413}
==========

[commit-bot: I haz the power, 2016-11-19 08:39:07]

Patchset 2 (id:??) landed as
https://crrev.com/1001cfaab4de5b1fdbc776908cc4113bc953a741
Cr-Commit-Position: refs/heads/master@{#433413}

[chanpatorikku, 2016-11-21 13:52:27]

Sending another message to inform that the (c) is going to be removed in another
CL.

https://codereview.chromium.org/2518593002/diff/1/native_client_sdk/src/libra...
File native_client_sdk/src/libraries/nacl_io/statuscode.h (right):

https://codereview.chromium.org/2518593002/diff/1/native_client_sdk/src/libra...
native_client_sdk/src/libraries/nacl_io/statuscode.h:1: // Copyright (c) 2016
The Chromium Authors. All rights reserved.
On 2016/11/18 17:32:30, Sam Clegg wrote:
> New files don't need the (c) here

Done.

(c) in other new files were added in other CL's. Going to remove the (c) in
another CL.

https://codereview.chromium.org/2518593002/diff/1/native_client_sdk/src/libra...
native_client_sdk/src/libraries/nacl_io/statuscode.h:14: const int32_t
STATUSCODE_REQUESTED_RANGE_NOT_SATISFIABLE = 416;
On 2016/11/18 17:32:30, Sam Clegg wrote:
> Perhaps call this file http_status_codes.h?

The file was renamed to http_status_codes.h.