Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2518573002: [ObjC ARC] Converts ios/chrome/browser/ui/webui:webui to ARC. (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/webui:webui to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/1c39ac38482e62040d3ad2f4678cafae8f56c4e2 Cr-Commit-Position: refs/heads/master@{#433533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M ios/chrome/browser/ui/webui/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/webui/version_ui.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
stkhapugin
PTAL. Passes downstream tests.🐈
4 years, 1 month ago (2016-11-21 13:08:44 UTC) #6
sdefresne
lgtm 😸
4 years, 1 month ago (2016-11-21 13:12:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518573002/1
4 years, 1 month ago (2016-11-21 13:27:13 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 14:18:11 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 14:22:00 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c39ac38482e62040d3ad2f4678cafae8f56c4e2
Cr-Commit-Position: refs/heads/master@{#433533}

Powered by Google App Engine
This is Rietveld 408576698