Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 2518553003: Mark some string operations as GVN-able. (Closed)

Created:
4 years, 1 month ago by sra1
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Mark some string operations as GVN-able. There are not many GVN optimizations, but knowing the calls are effect-free allows some fields to be load-eliminated, leading to the loaded value having a refined type. In a big app, about 20 calls to String.substring no longer need an interceptor. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a608c592fd41eed5288109358726605e6942b2c5

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 1 2 2 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 11 months ago (2017-01-11 22:37:03 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 11 months ago (2017-01-11 22:40:05 UTC) #3
sra1
3 years, 11 months ago (2017-01-12 03:51:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
a608c592fd41eed5288109358726605e6942b2c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698