Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2518513002: [turbofan] Add JSStoreDataPropertyInLiteral operator. (Closed)

Created:
4 years, 1 month ago by Franzi
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add JSStoreDataPropertyInLiteral operator. BUG=v8:5624 Committed: https://crrev.com/54e4b1fb5eafe5d275948bb5cd3ed39eee7ee083 Cr-Commit-Position: refs/heads/master@{#41119}

Patch Set 1 #

Patch Set 2 : Use operator in graph builder. #

Patch Set 3 : Fix FrameStateInput #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -25 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/js-operator.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 chunk +20 lines, -19 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
Franzi
PTAL
4 years, 1 month ago (2016-11-18 14:09:44 UTC) #9
Benedikt Meurer
Nice. LGTM.
4 years, 1 month ago (2016-11-18 18:25:03 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518513002/40001
4 years, 1 month ago (2016-11-18 18:25:44 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-18 18:27:50 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 18:28:25 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/54e4b1fb5eafe5d275948bb5cd3ed39eee7ee083
Cr-Commit-Position: refs/heads/master@{#41119}

Powered by Google App Engine
This is Rietveld 408576698