Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2518473002:
[Sync] Enable SyncBackendHostTest.FirstTimeSync on IOS (Closed)
|
Created:
4 years, 1 month ago by Gang Wu Modified:
4 years ago Reviewers:
Nicolas Zea CC:
chromium-reviews, sync-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Sync] Enable SyncBackendHostTest.FirstTimeSync on IOS
Tried several times on my local and try-bot, no repro.
all the logs in https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRjb21wb25lbnRzX3VuaXR0ZXN0cww
are invalid, so enable test to capture more failures.
BUG=659705
Committed: https://crrev.com/3b39bb26474066aef816f863b6c50053153fe190
Cr-Commit-Position: refs/heads/master@{#434198}
Patch Set 1 #
Total comments: 2
Patch Set 2 : remove MAYBE_ #Messages
Total messages: 21 (15 generated)
The CQ bit was checked by gangwu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== remove ios BUG= ========== to ========== [Sync] Enable SyncBackendHostTest.FirstTimeSync on IOS Tried several times on my local and try-bot, no repro. all the logs in https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9... are invalid, so enable test to capture more failures. BUG=659705 ==========
gangwu@chromium.org changed reviewers: + zea@chromium.org
PTAL
lgtm https://codereview.chromium.org/2518473002/diff/1/components/sync/driver/glue... File components/sync/driver/glue/sync_backend_host_impl_unittest.cc (right): https://codereview.chromium.org/2518473002/diff/1/components/sync/driver/glue... components/sync/driver/glue/sync_backend_host_impl_unittest.cc:297: #define MAYBE_FirstTimeSync FirstTimeSync nit: just remove this line, and rename the test back to FirstTimeSync. No reason to leave MAYBE_FirstTimeSync around.
The CQ bit was checked by gangwu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by gangwu@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org Link to the patchset: https://codereview.chromium.org/2518473002/#ps20001 (title: "remove MAYBE_")
https://codereview.chromium.org/2518473002/diff/1/components/sync/driver/glue... File components/sync/driver/glue/sync_backend_host_impl_unittest.cc (right): https://codereview.chromium.org/2518473002/diff/1/components/sync/driver/glue... components/sync/driver/glue/sync_backend_host_impl_unittest.cc:297: #define MAYBE_FirstTimeSync FirstTimeSync On 2016/11/23 00:49:21, Nicolas Zea wrote: > nit: just remove this line, and rename the test back to FirstTimeSync. No reason > to leave MAYBE_FirstTimeSync around. Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479922442994080,
"parent_rev": "da662a0cac47366b678faf57692e13129aa8e976", "commit_rev":
"e0ce6ccc05a0cc09214d2d7ad34b0a48ed73acc6"}
Message was sent while issue was closed.
Description was changed from ========== [Sync] Enable SyncBackendHostTest.FirstTimeSync on IOS Tried several times on my local and try-bot, no repro. all the logs in https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9... are invalid, so enable test to capture more failures. BUG=659705 ========== to ========== [Sync] Enable SyncBackendHostTest.FirstTimeSync on IOS Tried several times on my local and try-bot, no repro. all the logs in https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9... are invalid, so enable test to capture more failures. BUG=659705 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Sync] Enable SyncBackendHostTest.FirstTimeSync on IOS Tried several times on my local and try-bot, no repro. all the logs in https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9... are invalid, so enable test to capture more failures. BUG=659705 ========== to ========== [Sync] Enable SyncBackendHostTest.FirstTimeSync on IOS Tried several times on my local and try-bot, no repro. all the logs in https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9... are invalid, so enable test to capture more failures. BUG=659705 Committed: https://crrev.com/3b39bb26474066aef816f863b6c50053153fe190 Cr-Commit-Position: refs/heads/master@{#434198} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3b39bb26474066aef816f863b6c50053153fe190 Cr-Commit-Position: refs/heads/master@{#434198} |
