Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2518443002: Experimetal copy of https://codereview.chromium.org/2512783002/ (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
bbudge, reed1
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -31 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.h View 5 chunks +19 lines, -9 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 8 chunks +32 lines, -19 lines 0 comments Download
M printing/metafile_skia_wrapper.h View 1 chunk +3 lines, -1 line 0 comments Download
M printing/metafile_skia_wrapper.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
reed1
4 years, 1 month ago (2016-11-18 02:42:51 UTC) #4
reed1
I can't really "approve", but this achieves my aim of removing the dependency on SkCanvas ...
4 years, 1 month ago (2016-11-18 02:44:03 UTC) #5
Lei Zhang
4 years, 1 month ago (2016-11-18 02:50:13 UTC) #6 
On 2016/11/18 02:44:03, reed1 wrote:
> I can't really "approve", but this achieves my aim of removing the dependency
on
> SkCanvas being ref-counted.

I'm not trying to land this. I'm just experimenting with it. If the try bots are
happy, and you are happy, can you take it for your CL, which has all the
approvals?

Powered by Google App Engine
This is Rietveld 408576698