aw: Add new DrawGL modes

aw: Add new DrawGL modes

These new modes are currently unused.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267032

[boliu, 2014-04-28 22:56:24]

hush for review, sgurun for stamp

[sgurun-gerrit only, 2014-04-29 00:59:45]

On 2014/04/28 22:56:24, boliu wrote:
> hush for review, sgurun for stamp

Please put a comment on what these modes are for. lgtm

[boliu, 2014-04-29 01:37:09]

On 2014/04/29 00:59:45, sgurun wrote:
> On 2014/04/28 22:56:24, boliu wrote:
> > hush for review, sgurun for stamp
> 
> Please put a comment on what these modes are for. lgtm

Umm...see private/hwui/DrawGlInfo.h and discussion in b/12179257.

[sgurun-gerrit only, 2014-04-29 01:52:12]

On 2014/04/29 01:37:09, boliu wrote:
> On 2014/04/29 00:59:45, sgurun wrote:
> > On 2014/04/28 22:56:24, boliu wrote:
> > > hush for review, sgurun for stamp
> > 
> > Please put a comment on what these modes are for. lgtm
> 
> Umm...see private/hwui/DrawGlInfo.h and discussion in b/12179257.

sg

[hush (inactive), 2014-04-29 17:21:44]

https://codereview.chromium.org/251843006/diff/1/android_webview/browser/hard...
File android_webview/browser/hardware_renderer.cc (right):

https://codereview.chromium.org/251843006/diff/1/android_webview/browser/hard...
android_webview/browser/hardware_renderer.cc:93: if (draw_info->mode !=
AwDrawGLInfo::kModeDraw)
is it true that we only access the shared renderer state in kModeDraw and no
other modes? (kModeProcess, kModeProcessNoContext, kModeSync)
put a comment here?

[boliu, 2014-04-29 17:33:53]

https://codereview.chromium.org/251843006/diff/1/android_webview/browser/hard...
File android_webview/browser/hardware_renderer.cc (right):

https://codereview.chromium.org/251843006/diff/1/android_webview/browser/hard...
android_webview/browser/hardware_renderer.cc:93: if (draw_info->mode !=
AwDrawGLInfo::kModeDraw)
On 2014/04/29 17:21:44, hush wrote:
> is it true that we only access the shared renderer state in kModeDraw and no
> other modes? (kModeProcess, kModeProcessNoContext, kModeSync)
> put a comment here?

Done.

[hush (inactive), 2014-04-29 17:39:25]

lgtm

[commit-bot: I haz the power, 2014-04-29 17:41:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/251843006/20001

[commit-bot: I haz the power, 2014-04-29 17:52:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 17:52:42]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium

[boliu, 2014-04-29 17:53:15]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-04-29 17:54:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/251843006/20001

[commit-bot: I haz the power, 2014-04-29 19:23:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 19:23:11]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium

[boliu, 2014-04-29 19:23:48]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-04-29 19:27:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/251843006/20001

[commit-bot: I haz the power, 2014-04-29 21:44:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 21:44:22]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium

[boliu, 2014-04-30 00:48:02]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-04-30 00:50:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/boliu@chromium.org/251843006/20001

[commit-bot: I haz the power, 2014-04-30 01:37:27]

Change committed as 267032