ash/common/shelf/shelf_window_watcher_unittest.cc - Issue 2518423003: Combine shelf platform and windowed app types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/shelf/shelf_window_watcher_unittest.cc

Issue 2518423003: Combine shelf platform and windowed app types. (Closed)

Patch Set: Update platform-app test support; address comment; format. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/shelf/shelf_window_watcher_unittest.cc

diff --git a/ash/common/shelf/shelf_window_watcher_unittest.cc b/ash/common/shelf/shelf_window_watcher_unittest.cc

index 7817ea1dcde7c31894b082f9dc3b0f9f6b052492..6e772bc347c53cb4821c3bcce195627feabe9dc2 100644

--- a/ash/common/shelf/shelf_window_watcher_unittest.cc

+++ b/ash/common/shelf/shelf_window_watcher_unittest.cc

@@ -157,7 +157,7 @@ TEST_F(ShelfWindowWatcherTest, UpdateWindowProperty) {

EXPECT_EQ(STATUS_ACTIVE, model_->items()[index].status);

// Update the ShelfItemType for |window|.

- window->SetIntProperty(WmWindowProperty::SHELF_ITEM_TYPE, TYPE_PLATFORM_APP);

+ window->SetIntProperty(WmWindowProperty::SHELF_ITEM_TYPE, TYPE_APP);

// No new item is created after updating a launcher item.

EXPECT_EQ(2, model_->item_count());

// index and id are not changed after updating a launcher item.