Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2083)

Unified Diff: ash/common/shelf/shelf_item_types.h

Issue 2518423003: Combine shelf platform and windowed app types. (Closed)
Patch Set: Update platform-app test support; address comment; format. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/common/shelf/shelf_model.cc » ('j') | ash/common/shelf/shelf_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/shelf_item_types.h
diff --git a/ash/common/shelf/shelf_item_types.h b/ash/common/shelf/shelf_item_types.h
index c09a06433649dd44bea3f47b2d39fa74e8b01551..2f05e8c5f60be906eb70d0da6a978ae0f486225d 100644
--- a/ash/common/shelf/shelf_item_types.h
+++ b/ash/common/shelf/shelf_item_types.h
@@ -30,11 +30,8 @@ enum ShelfItemType {
// The browser shortcut button.
TYPE_BROWSER_SHORTCUT,
- // Represents a platform app.
- TYPE_PLATFORM_APP,
-
- // Represents a windowed V1 browser app.
- TYPE_WINDOWED_APP,
+ // Represents an app (platform/V2 or windowed V1 browser).
James Cook 2016/11/28 22:57:47 Can you clarify the various sorts of apps in this
msw 2016/11/28 23:47:41 I don't feel highly experienced here, but I tried
+ TYPE_APP,
// Represents a dialog.
TYPE_DIALOG,
« no previous file with comments | « no previous file | ash/common/shelf/shelf_model.cc » ('j') | ash/common/shelf/shelf_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698