Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4469)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h

Issue 2518423003: Combine shelf platform and windowed app types. (Closed)
Patch Set: Fix kInvalidShelfID typo. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/shell/window_watcher.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
index 64aefaa270f2e3ad726993387d60c725419e94c0..caf4fdc30c720a728fb52751dd2fe8c601e2d6d4 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
@@ -115,9 +115,9 @@ class ChromeLauncherController : public ash::mojom::ShelfObserver,
// be pinned.
virtual bool IsPinnable(ash::ShelfID id) const = 0;
- // If there is no shelf item in the shelf for application |app_id|, one
- // gets created. The (existing or created) shelf items get then locked
- // against a users un-pinning removal.
+ // If there is no item in the shelf for application |app_id|, one is created.
+ // The (existing or created) shelf items get then locked against a user's
+ // un-pinning removal. Used for V1 apps opened as windows that aren't pinned.
virtual void LockV1AppWithID(const std::string& app_id) = 0;
// A previously locked shelf item of type |app_id| gets unlocked. If the
@@ -158,10 +158,6 @@ class ChromeLauncherController : public ash::mojom::ShelfObserver,
virtual void SetLauncherItemImage(ash::ShelfID shelf_id,
const gfx::ImageSkia& image) = 0;
- // Find out if the given application |id| is a windowed app item and not a
- // pinned item in the shelf.
- virtual bool IsWindowedAppInLauncher(const std::string& app_id) = 0;
-
// Updates the launch type of the app for the specified id to |launch_type|.
virtual void SetLaunchType(ash::ShelfID id,
extensions::LaunchType launch_type) = 0;
« no previous file with comments | « ash/shell/window_watcher.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698