Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: ash/mus/bridge/wm_window_mus.cc

Issue 2518423003: Combine shelf platform and windowed app types. (Closed)
Patch Set: Fix kInvalidShelfID typo. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/common/test/test_shelf_delegate.cc ('k') | ash/shelf/shelf_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/mus/bridge/wm_window_mus.h" 5 #include "ash/mus/bridge/wm_window_mus.h"
6 6
7 #include "ash/common/shelf/shelf_item_types.h" 7 #include "ash/common/shelf/shelf_item_types.h"
8 #include "ash/common/wm/container_finder.h" 8 #include "ash/common/wm/container_finder.h"
9 #include "ash/common/wm/window_positioning_utils.h" 9 #include "ash/common/wm/window_positioning_utils.h"
10 #include "ash/common/wm/window_state.h" 10 #include "ash/common/wm/window_state.h"
(...skipping 422 matching lines...) Expand 10 before | Expand all | Expand 10 after
433 return kInvalidShelfID; 433 return kInvalidShelfID;
434 } 434 }
435 435
436 if (key == WmWindowProperty::SHELF_ITEM_TYPE) { 436 if (key == WmWindowProperty::SHELF_ITEM_TYPE) {
437 if (window_->HasSharedProperty( 437 if (window_->HasSharedProperty(
438 ui::mojom::WindowManager::kShelfItemType_Property)) { 438 ui::mojom::WindowManager::kShelfItemType_Property)) {
439 return window_->GetSharedProperty<int>( 439 return window_->GetSharedProperty<int>(
440 ui::mojom::WindowManager::kShelfItemType_Property); 440 ui::mojom::WindowManager::kShelfItemType_Property);
441 } 441 }
442 // Mash provides a default shelf item type for non-ignored windows. 442 // Mash provides a default shelf item type for non-ignored windows.
443 return GetWindowIgnoredByShelf(window_) ? TYPE_UNDEFINED 443 return GetWindowIgnoredByShelf(window_) ? TYPE_UNDEFINED : TYPE_APP;
444 : TYPE_PLATFORM_APP;
445 } 444 }
446 445
447 if (key == WmWindowProperty::TOP_VIEW_INSET) { 446 if (key == WmWindowProperty::TOP_VIEW_INSET) {
448 // TODO: need support for TOP_VIEW_INSET: http://crbug.com/615100. 447 // TODO: need support for TOP_VIEW_INSET: http://crbug.com/615100.
449 NOTIMPLEMENTED(); 448 NOTIMPLEMENTED();
450 return 0; 449 return 0;
451 } 450 }
452 451
453 NOTREACHED(); 452 NOTREACHED();
454 return 0; 453 return 0;
(...skipping 588 matching lines...) Expand 10 before | Expand all | Expand 10 after
1043 } 1042 }
1044 1043
1045 void WmWindowMus::OnTransientChildRemoved(ui::Window* window, 1044 void WmWindowMus::OnTransientChildRemoved(ui::Window* window,
1046 ui::Window* transient) { 1045 ui::Window* transient) {
1047 for (auto& observer : transient_observers_) 1046 for (auto& observer : transient_observers_)
1048 observer.OnTransientChildRemoved(this, Get(transient)); 1047 observer.OnTransientChildRemoved(this, Get(transient));
1049 } 1048 }
1050 1049
1051 } // namespace mus 1050 } // namespace mus
1052 } // namespace ash 1051 } // namespace ash
OLDNEW
« no previous file with comments | « ash/common/test/test_shelf_delegate.cc ('k') | ash/shelf/shelf_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698