media: Use __func__ instead of __FUNCTION__

media: Use __func__ instead of __FUNCTION__

__func__ is the c++11 standard replacement for non-standard
__FUNCTION__. See https://chromium-cpp.appspot.com/

This is a mechanical change, done with:

> git grep --name-only __FUNCTION__ \
    | xargs sed -i 's/__FUNCTION__/__func__/g'
> git cl format

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7dd3af9a96fb329f9ee0ec0cb7de45247872bbc4
Cr-Commit-Position: refs/heads/master@{#436057}

[watk, 2016-11-22 23:05:30]

Description was changed from

==========
media: Use __func__ instead of __FUNCTION__

Mechanical change to update to __func__:

> git grep --name-only __FUNCTION__ \
    | xargs sed -i 's/__FUNCTION__/__func__/g'
> git cl format
==========

to

==========
media: Use __func__ instead of __FUNCTION__

Mechanical change to update to __func__:

> git grep --name-only __FUNCTION__ \
    | xargs sed -i 's/__FUNCTION__/__func__/g'
> git cl format
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[watk, 2016-11-22 23:06:19]

Description was changed from

==========
media: Use __func__ instead of __FUNCTION__

Mechanical change to update to __func__:

> git grep --name-only __FUNCTION__ \
    | xargs sed -i 's/__FUNCTION__/__func__/g'
> git cl format
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
media: Use __func__ instead of __FUNCTION__

Mechanical change to update to __func__:

> git grep --name-only __FUNCTION__ \
    | xargs sed -i 's/__FUNCTION__/__func__/g'
> git cl format

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[watk, 2016-11-22 23:06:19]

watk@chromium.org changed reviewers:
+ xhwang@chromium.org

[watk, 2016-11-22 23:09:17]

PTAL. I found myself changing these manually when touching nearby code, so why
not do it all at once. Git blame isn't really affected because these lines
aren't interesting. I just scanned the diff.. the sed replacement should be
pretty robust.

[watk, 2016-11-22 23:10:57]

The CQ bit was checked by watk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 23:11:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xhwang, 2016-11-22 23:30:41]

Could you please provide more context in the CL description why we prefer
__func__ to __FUNCTION__? Maybe with a link to some doc as well, e.g.

https://gcc.gnu.org/onlinedocs/gcc-4.8.1/gcc/Function-Names.html

[watk, 2016-11-22 23:52:36]

Description was changed from

==========
media: Use __func__ instead of __FUNCTION__

Mechanical change to update to __func__:

> git grep --name-only __FUNCTION__ \
    | xargs sed -i 's/__FUNCTION__/__func__/g'
> git cl format

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
media: Use __func__ instead of __FUNCTION__

__func__ is the c++11 standard replacement for non-standard
__FUNCTION__. See https://chromium-cpp.appspot.com/

This is a mechanical change, done with:

> git grep --name-only __FUNCTION__ \
    | xargs sed -i 's/__FUNCTION__/__func__/g'
> git cl format

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[watk, 2016-11-22 23:52:51]

Updated

[xhwang, 2016-11-22 23:58:40]

lgtm

[commit-bot: I haz the power, 2016-11-22 23:58:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 23:58:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[xhwang, 2016-11-22 23:59:19]

BTW, I like this patch :)

[watk, 2016-11-23 00:00:43]

On 2016/11/22 23:59:19, xhwang wrote:
> BTW, I like this patch :)

Thanks! The old chromium-dev thread was fresh in my mind so I didn't think to
add context.

[watk, 2016-12-02 20:25:22]

The CQ bit was checked by watk@chromium.org

[commit-bot: I haz the power, 2016-12-02 20:25:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 20:29:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 20:29:40]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[watk, 2016-12-02 20:38:32]

The CQ bit was checked by watk@chromium.org

[watk, 2016-12-02 20:38:33]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2518403004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-02 20:39:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 22:37:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480711112553250,
"parent_rev": "da099e1f3ee2757767ce244df70ee11ae1b4a9e8", "commit_rev":
"32164f31d25e4454f90fca3b7f4980cdac192e46"}

[commit-bot: I haz the power, 2016-12-02 22:38:18]

Description was changed from

==========
media: Use __func__ instead of __FUNCTION__

__func__ is the c++11 standard replacement for non-standard
__FUNCTION__. See https://chromium-cpp.appspot.com/

This is a mechanical change, done with:

> git grep --name-only __FUNCTION__ \
    | xargs sed -i 's/__FUNCTION__/__func__/g'
> git cl format

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
media: Use __func__ instead of __FUNCTION__

__func__ is the c++11 standard replacement for non-standard
__FUNCTION__. See https://chromium-cpp.appspot.com/

This is a mechanical change, done with:

> git grep --name-only __FUNCTION__ \
    | xargs sed -i 's/__FUNCTION__/__func__/g'
> git cl format

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-12-02 22:38:20]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-02 22:41:20]

Description was changed from

==========
media: Use __func__ instead of __FUNCTION__

__func__ is the c++11 standard replacement for non-standard
__FUNCTION__. See https://chromium-cpp.appspot.com/

This is a mechanical change, done with:

> git grep --name-only __FUNCTION__ \
    | xargs sed -i 's/__FUNCTION__/__func__/g'
> git cl format

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
media: Use __func__ instead of __FUNCTION__

__func__ is the c++11 standard replacement for non-standard
__FUNCTION__. See https://chromium-cpp.appspot.com/

This is a mechanical change, done with:

> git grep --name-only __FUNCTION__ \
    | xargs sed -i 's/__FUNCTION__/__func__/g'
> git cl format

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7dd3af9a96fb329f9ee0ec0cb7de45247872bbc4
Cr-Commit-Position: refs/heads/master@{#436057}
==========

[commit-bot: I haz the power, 2016-12-02 22:41:22]

Patchset 2 (id:??) landed as
https://crrev.com/7dd3af9a96fb329f9ee0ec0cb7de45247872bbc4
Cr-Commit-Position: refs/heads/master@{#436057}