third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp - Issue 2518363003: Refactor InlineBox::calculateBoundaries()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

Issue 2518363003: Refactor InlineBox::calculateBoundaries() (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

index 00bcca6123ac82b211e3336b6e16277902eb6b2c..d039ad689db6a1c26a3a5cf760c4651d110c5ef6 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp

@@ -2444,7 +2444,7 @@ void InspectorCSSAgent::visitLayoutTreeNodes(

protocol::Array<protocol::CSS::InlineTextBox>::create();

for (const InlineTextBox* textBox = layoutText->firstTextBox(); textBox;

textBox = textBox->nextTextBox()) {

- FloatRect localCoordsTextBoxRect(textBox->calculateBoundaries());

+ FloatRect localCoordsTextBoxRect(textBox->frameRect());

FloatRect absoluteCoordsTextBoxRect =

layoutObject->localToAbsoluteQuad(localCoordsTextBoxRect)

.boundingBox();