Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2518363002:
Disable ui::Clipboard on the FILE thread. (Closed)
DescriptionDisable ui::Clipboard on the FILE thread.
We found no evidence that ui::Clipboard is used on the
FILE thread. This CL disallows usage of ui::Clipboard on
the FILE thread and adds a DumpWithoutCrashing() call to
detect when it's used on unauthorized threads.
Disallowing usage of ui::Clipboard on the FILE thread
will facilitate its migration to TaskScheduler.
BUG=662055
Committed: https://crrev.com/d1e683e0e48535837caf622ae70b14fa57e7a392
Cr-Commit-Position: refs/heads/master@{#434178}
Patch Set 1 #Patch Set 2 : dump without crashing #Patch Set 3 : fix build error #Patch Set 4 : fix build error #
Messages
Total messages: 28 (20 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== No clipboard on the FILE thread. BUG= ========== to ========== Disable ui::Clipboard on the FILE thread. We found no evidence that ui::Clipboard is used on the FILE thread. This CL adds a DCHECK and a DumpWithoutCrashing to verify that it is indeed not used on the FILE thread (DumpWithoutCrashing will provide data from the wild). BUG=662055 ==========
fdoray@chromium.org changed reviewers: + dcheng@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/11/22 21:09:35, fdoray wrote: > PTAL Apparently I rewrote this in https://codereview.chromium.org/1876653003 so it no longer uses the FILE thread. AFAIK, that should have been the only usage. TBH, I'd be OK with just removing the DumpWithoutCrashing(). LGTM either way though.
Description was changed from ========== Disable ui::Clipboard on the FILE thread. We found no evidence that ui::Clipboard is used on the FILE thread. This CL adds a DCHECK and a DumpWithoutCrashing to verify that it is indeed not used on the FILE thread (DumpWithoutCrashing will provide data from the wild). BUG=662055 ========== to ========== Disable ui::Clipboard on the FILE thread. We found no evidence that ui::Clipboard is used on the FILE thread. This CL disallows usage of ui::Clipboard on the FILE thread and adds a DumpWithoutCrashing() call to detect when it's used on unauthorized threads. Disallowing usage of ui::Clipboard on the FILE thread will facilitate its migration to TaskScheduler. BUG=662055 ==========
On 2016/11/23 00:56:52, dcheng wrote: > On 2016/11/22 21:09:35, fdoray wrote: > > PTAL > > Apparently I rewrote this in https://codereview.chromium.org/1876653003 so it no > longer uses the FILE thread. AFAIK, that should have been the only usage. TBH, > I'd be OK with just removing the DumpWithoutCrashing(). > > LGTM either way though. I prefer keeping DumpWithoutCrashing() for ~1 week on Canary to avoid missing some usage of ui::Clipboard on the FILE thread.
fdoray@chromium.org changed reviewers: + avi@chromium.org
avi@: Please review changes in content/
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479917642732070,
"parent_rev": "f652fde0cded0568bd221b15504282ff4f24b133", "commit_rev":
"52be7496fa5c1e3971a93557da58ef34f6783a0c"}
Message was sent while issue was closed.
Description was changed from ========== Disable ui::Clipboard on the FILE thread. We found no evidence that ui::Clipboard is used on the FILE thread. This CL disallows usage of ui::Clipboard on the FILE thread and adds a DumpWithoutCrashing() call to detect when it's used on unauthorized threads. Disallowing usage of ui::Clipboard on the FILE thread will facilitate its migration to TaskScheduler. BUG=662055 ========== to ========== Disable ui::Clipboard on the FILE thread. We found no evidence that ui::Clipboard is used on the FILE thread. This CL disallows usage of ui::Clipboard on the FILE thread and adds a DumpWithoutCrashing() call to detect when it's used on unauthorized threads. Disallowing usage of ui::Clipboard on the FILE thread will facilitate its migration to TaskScheduler. BUG=662055 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Disable ui::Clipboard on the FILE thread. We found no evidence that ui::Clipboard is used on the FILE thread. This CL disallows usage of ui::Clipboard on the FILE thread and adds a DumpWithoutCrashing() call to detect when it's used on unauthorized threads. Disallowing usage of ui::Clipboard on the FILE thread will facilitate its migration to TaskScheduler. BUG=662055 ========== to ========== Disable ui::Clipboard on the FILE thread. We found no evidence that ui::Clipboard is used on the FILE thread. This CL disallows usage of ui::Clipboard on the FILE thread and adds a DumpWithoutCrashing() call to detect when it's used on unauthorized threads. Disallowing usage of ui::Clipboard on the FILE thread will facilitate its migration to TaskScheduler. BUG=662055 Committed: https://crrev.com/d1e683e0e48535837caf622ae70b14fa57e7a392 Cr-Commit-Position: refs/heads/master@{#434178} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/d1e683e0e48535837caf622ae70b14fa57e7a392 Cr-Commit-Position: refs/heads/master@{#434178} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
