Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(799)

Unified Diff: media/filters/video_frame_scheduler_proxy.h

Issue 251833004: Make VideoFrameSchedulerProxy own the scheduler it is proxying. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/filters/video_frame_scheduler_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/video_frame_scheduler_proxy.h
diff --git a/media/filters/video_frame_scheduler_proxy.h b/media/filters/video_frame_scheduler_proxy.h
index d17fb5632bc3e9a3ce1dc32b4659e1f38b60b7f5..9130f603f1bc6208a876f4807950120d8805905c 100644
--- a/media/filters/video_frame_scheduler_proxy.h
+++ b/media/filters/video_frame_scheduler_proxy.h
@@ -22,11 +22,11 @@ class MEDIA_EXPORT VideoFrameSchedulerProxy : public VideoFrameScheduler {
public:
// |task_runner| is the runner that this object will be called on.
// |scheduler_runner| is the runner that |scheduler| will be called on.
- // |scheduler| must out-live the lifetime of this object.
+ // |scheduler| will be deleted on |scheduler_runner|.
VideoFrameSchedulerProxy(
const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
const scoped_refptr<base::SingleThreadTaskRunner>& scheduler_runner,
- VideoFrameScheduler* scheduler);
+ scoped_ptr<VideoFrameScheduler> scheduler);
virtual ~VideoFrameSchedulerProxy();
// VideoFrameScheduler implementation.
@@ -38,7 +38,7 @@ class MEDIA_EXPORT VideoFrameSchedulerProxy : public VideoFrameScheduler {
private:
scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
scoped_refptr<base::SingleThreadTaskRunner> scheduler_runner_;
- VideoFrameScheduler* scheduler_; // Not owned.
+ scoped_ptr<VideoFrameScheduler> scheduler_;
// NOTE: Weak pointers must be invalidated before all other member variables.
base::WeakPtrFactory<VideoFrameSchedulerProxy> weak_factory_;
« no previous file with comments | « no previous file | media/filters/video_frame_scheduler_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698