Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_unittest.py

Issue 2518313003: Refactor WPT Export to ensure only one PR in flight at a time (Closed)
Patch Set: Address CL feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_mock.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/github_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_unittest.py
similarity index 58%
rename from third_party/WebKit/Tools/Scripts/webkitpy/w3c/github_unittest.py
rename to third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_unittest.py
index 9bc6ea1cac2a7f6682e647b83b77ed4790b8a966..aebcc45eae35ec027c0ebded5a7bb8b4fe1aa531 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/github_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_unittest.py
@@ -5,40 +5,38 @@
import base64
import unittest
from webkitpy.common.host_mock import MockHost
-from webkitpy.w3c.github import GitHub
+from webkitpy.w3c.wpt_github import WPTGitHub
-class GitHubEnvTest(unittest.TestCase):
+class WPTGitHubEnvTest(unittest.TestCase):
def setUp(self):
self.host = MockHost()
def test_requires_env_vars(self):
- self.assertRaises(AssertionError, lambda: GitHub(self.host))
+ self.assertRaises(AssertionError, lambda: WPTGitHub(self.host))
def test_requires_gh_user_env_var(self):
self.host.environ['GH_USER'] = 'rutabaga'
- self.assertRaises(AssertionError, lambda: GitHub(self.host))
+ self.assertRaises(AssertionError, lambda: WPTGitHub(self.host))
def test_requires_gh_token_env_var(self):
self.host.environ['GH_TOKEN'] = 'deadbeefcafe'
- self.assertRaises(AssertionError, lambda: GitHub(self.host))
+ self.assertRaises(AssertionError, lambda: WPTGitHub(self.host))
-class GitHubTest(unittest.TestCase):
+class WPTGitHubTest(unittest.TestCase):
def setUp(self):
self.host = MockHost()
self.host.environ['GH_USER'] = 'rutabaga'
self.host.environ['GH_TOKEN'] = 'deadbeefcafe'
- self.github = GitHub(self.host)
+ self.wpt_github = WPTGitHub(self.host)
def test_properties(self):
- self.assertEqual(self.github.user, 'rutabaga')
- self.assertEqual(self.github.token, 'deadbeefcafe')
+ self.assertEqual(self.wpt_github.user, 'rutabaga')
+ self.assertEqual(self.wpt_github.token, 'deadbeefcafe')
def test_auth_token(self):
expected = base64.encodestring('rutabaga:deadbeefcafe')
- self.assertEqual(self.github.auth_token(), expected)
-
- # TODO(jeffcarp): add create_pr tests
+ self.assertEqual(self.wpt_github.auth_token(), expected)
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_mock.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698