Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py

Issue 2518313003: Refactor WPT Export to ensure only one PR in flight at a time (Closed)
Patch Set: Address CL feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py
index f7e4d4066f3cea76d28ce884084090190a26df55..efcb483793b71d0e490f4aefb5fef9eef41ac658 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/sync_wpt.py
@@ -15,11 +15,8 @@ import argparse
import logging
from webkitpy.common.host import Host
-from webkitpy.common.system.executive import ScriptError
-from webkitpy.w3c.chromium_commit import ChromiumCommit
-from webkitpy.w3c.chromium_wpt import ChromiumWPT
-from webkitpy.w3c.github import GitHub
-from webkitpy.w3c.local_wpt import LocalWPT
+from webkitpy.w3c.wpt_github import WPTGitHub
+from webkitpy.w3c.test_exporter import TestExporter
from webkitpy.w3c.test_importer import configure_logging
_log = logging.getLogger(__name__)
@@ -29,45 +26,14 @@ def main():
configure_logging()
options = parse_args()
host = Host()
- github = GitHub(host)
+ wpt_github = WPTGitHub(host)
+ test_exporter = TestExporter(host, wpt_github, dry_run=options.dry_run)
- local_wpt = LocalWPT(host, no_fetch=options.no_fetch, use_github=True)
- chromium_wpt = ChromiumWPT(host)
-
- wpt_commit, chromium_commit = local_wpt.most_recent_chromium_commit()
- assert chromium_commit, 'No Chromium commit found, this is impossible'
-
- _log.info('web-platform-tests@%s (%d behind origin/master)',
- wpt_commit, local_wpt.commits_behind_master(wpt_commit))
- _log.info('chromium@%s (%d behind origin/master)',
- chromium_commit.sha, chromium_commit.num_behind_master())
-
- exportable_commits = chromium_wpt.exportable_commits_since(chromium_commit.sha)
-
- if exportable_commits:
- _log.info('Found %s exportable commits in chromium:', len(exportable_commits))
- for commit in exportable_commits:
- _log.info('- %s %s', commit, chromium_wpt.subject(commit))
- else:
- _log.info('No exportable commits found in Chromium, stopping.')
- return
-
- for commit in exportable_commits:
- _log.info('Uploading %s', chromium_wpt.subject(commit))
- chromium_commit = ChromiumCommit(host, sha=commit)
-
- patch = chromium_wpt.format_patch(commit)
- message = chromium_wpt.message(commit)
-
- local_wpt.create_branch_with_patch(branch_name, message, patch)
-
- github.create_pr(
- local_branch_name='chromium-try-{}'.format(commit),
- desc_title=chromium_commit.subject(),
- body=chromium_commit.body())
+ test_exporter.run()
def parse_args():
parser = argparse.ArgumentParser(description='WPT Sync')
parser.add_argument('--no-fetch', action='store_true')
+ parser.add_argument('--dry-run', action='store_true')
return parser.parse_args()

Powered by Google App Engine
This is Rietveld 408576698