Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py

Issue 2518313003: Refactor WPT Export to ensure only one PR in flight at a time (Closed)
Patch Set: Address CL feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
index 805403c8f2bf914e9d735624d259f03b72e75228..d7217c0999415007a3f5e9ea49322a3559e2f160 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
@@ -72,17 +72,16 @@ class LocalWPT(object):
"""Returns a list of local and remote branches."""
return self.run(['git', 'branch', '-a']).splitlines()
- def create_branch_with_patch(self, branch_name, message, patch):
+ def create_branch_with_patch(self, message, patch):
"""Commits the given patch and pushes to the upstream repo.
Args:
- branch_name: A name that is used for both the local branch
- and the remote branch on github.
message: Commit message string.
patch: A patch that can be applied by git apply.
"""
self.clean()
all_branches = self.all_branches()
+ branch_name = 'chromium-export-try'
remote_branch_name = 'remotes/github/%s' % branch_name
if branch_name in all_branches:
@@ -106,6 +105,8 @@ class LocalWPT(object):
self.run(['git', 'commit', '-am', message])
self.run(['git', 'push', 'github', branch_name])
+ return branch_name
+
def commits_behind_master(self, commit):
"""Returns the number of commits after the given commit on origin/master.

Powered by Google App Engine
This is Rietveld 408576698