Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2518313002: [turbofan] Fix broken effect chain for instanceof. (Closed)

Created:
4 years ago by Benedikt Meurer
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix broken effect chain for instanceof. BUG=chromium:667689 R=jarin@chromium.org Committed: https://crrev.com/84c9360b82127571548c9d93132819a4174a0ea1 Cr-Commit-Position: refs/heads/master@{#41169}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +1 line, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-667689.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years ago (2016-11-22 10:27:27 UTC) #1
Jarin
lgtm
4 years ago (2016-11-22 10:32:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518313002/1
4 years ago (2016-11-22 10:35:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-22 11:05:07 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-22 11:05:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84c9360b82127571548c9d93132819a4174a0ea1
Cr-Commit-Position: refs/heads/master@{#41169}

Powered by Google App Engine
This is Rietveld 408576698