Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2518303002: M55: Fix CrOS reverting to Save as PDF and random PDF preview fail (Closed)

Created:
4 years ago by Lei Zhang
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

M55: Fix CrOS reverting to Save as PDF and random PDF preview fail Increasing number of saved destinations caused a bug on Chrome OS - destination always reverted to Save as PDF. Also caused random "PDF failed to load" preview errors. This occurred since the destinations were modified one after the other too quickly, which caused a race condition that crashed PDF preview. This error occurred ~1 in 10 times. BUG=665455, 666426, 666595 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2516523002 Cr-Commit-Position: refs/heads/master@{#433408} (cherry picked from commit b12aba73d3525867511b315a45d2dbc65acd2647) Committed: https://chromium.googlesource.com/chromium/src/+/03dfb68a8d7f607a19a3a5f53319c02b899f7d3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -78 lines) Patch
M chrome/browser/resources/print_preview/data/app_state.js View 1 chunk +2 lines, -62 lines 0 comments Download
M chrome/browser/resources/print_preview/data/destination_store.js View 7 chunks +26 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Lei Zhang
4 years ago (2016-11-22 10:09:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
03dfb68a8d7f607a19a3a5f53319c02b899f7d3f.

Powered by Google App Engine
This is Rietveld 408576698