Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2518263002: Report a peer address over IPv4 as IPv4. (Closed)

Created:
4 years, 1 month ago by rmacnak
Modified:
4 years, 1 month ago
Reviewers:
zra, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -40 lines) Patch
M runtime/bin/socket.cc View 1 chunk +1 line, -1 line 0 comments Download
A + tests/standalone/io/socket_info_ipv4_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download
A + tests/standalone/io/socket_info_ipv6_test.dart View 1 chunk +8 lines, -4 lines 0 comments Download
D tests/standalone/io/socket_info_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 1 month ago (2016-11-22 04:46:57 UTC) #2
siva
lgtm
4 years, 1 month ago (2016-11-22 05:03:13 UTC) #3
rmacnak
4 years, 1 month ago (2016-11-22 17:19:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c45f24fa6c79823f4dcd43bb149d17b40e0718f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698