Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: base/BUILD.gn

Issue 2518253002: Move Partition Allocator into Chromium base. (Closed)
Patch Set: Remove PRETTY_FUNCTION, and fix (?) ByteSwap for uintptr_t on macOS/iOS. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/allocator/OWNERS » ('j') | base/logging.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 3d21aa4d350f80608c2feb07147b38de405386cb..b0ec3333a520fd5ae549dd603c1c5c40af6b7426 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1223,6 +1223,17 @@ component("base") {
"rand_util_nacl.cc",
"synchronization/read_write_lock_nacl.cc",
]
+
+ # Add stuff that doesn't work in NaCl.
+ sources += [
+ # PartitionAlloc uses SpinLock, which doesn't work in NaCl (see below).
+ "allocator/partition_allocator/address_space_randomization.cc",
+ "allocator/partition_allocator/address_space_randomization.h",
+ "allocator/partition_allocator/page_allocator.cc",
+ "allocator/partition_allocator/page_allocator.h",
+ "allocator/partition_allocator/partition_alloc.cc",
+ "allocator/partition_allocator/partition_alloc.h",
+ ]
}
# SpinLock uses inline assembly that doesn't work on NaCl, and for which there
@@ -1783,6 +1794,7 @@ if (is_ios || is_mac) {
test("base_unittests") {
sources = [
+ "allocator/partition_allocator/partition_alloc_unittest.cc",
"allocator/tcmalloc_unittest.cc",
"android/application_status_listener_unittest.cc",
"android/content_uri_utils_unittest.cc",
« no previous file with comments | « no previous file | base/allocator/OWNERS » ('j') | base/logging.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698