Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: base/BUILD.gn

Issue 2518253002: Move Partition Allocator into Chromium base. (Closed)
Patch Set: Respond to comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/BUILD.gn
diff --git a/base/BUILD.gn b/base/BUILD.gn
index 3059a19736fc350b00fca03cd49a62447344df47..21ae4be4d4d5ff07dfbce1cb3606061193dfa394 100644
--- a/base/BUILD.gn
+++ b/base/BUILD.gn
@@ -1214,6 +1214,21 @@ component("base") {
"rand_util_nacl.cc",
"synchronization/read_write_lock_nacl.cc",
]
+
+ # Add stuff that doesn't work in NaCl.
+ sources += [
+ # PartitionAlloc uses SpinLock, which doesn't work in NaCl (see below).
Primiano Tucci (use gerrit) 2016/11/28 12:06:50 you are moving the partition_alloc_unittest.cc but
palmer 2016/12/01 00:48:23 Thanks, fixed.
+ "allocator/partition_allocator/address_space_randomization.cc",
+ "allocator/partition_allocator/address_space_randomization.h",
+ "allocator/partition_allocator/page_allocator.cc",
+ "allocator/partition_allocator/page_allocator.h",
+ "allocator/partition_allocator/partition_alloc.cc",
+ "allocator/partition_allocator/partition_alloc.h",
+ "allocator/partition_allocator/partition_allocator.cc",
+ "allocator/partition_allocator/partition_allocator.h",
+ "allocator/partition_allocator/partitions.cc",
+ "allocator/partition_allocator/partitions.h",
+ ]
}
# SpinLock uses inline assembly that doesn't work on NaCl, and for which there
« no previous file with comments | « no previous file | base/allocator/OWNERS » ('j') | base/allocator/partition_allocator/address_space_randomization.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698