Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2518243002: Revert of [Autofill]Enable mojo AutofillDriver for android_webview. (Closed)

Created:
4 years, 1 month ago by sgurun-gerrit only
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert of [Autofill]Enable mojo AutofillDriver for android_webview. (patchset #1 id:1 of https://codereview.chromium.org/2517253003/ ) Reason for revert: breaks build. Original issue's description: > [Autofill]Enable mojo AutofillDriver for android_webview. > > BUG=662040 > > Review-Url: https://codereview.chromium.org/2491103003 > Cr-Commit-Position: refs/heads/master@{#433418} > (cherry picked from commit e404109db1d011479ea0fee59c5d415f44d73b22) > > Committed: https://chromium.googlesource.com/chromium/src/+/2da1a8d4e2a5289b195e6de4335d216f9ddf6758 TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=662040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M android_webview/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M android_webview/browser/aw_content_browser_client.cc View 3 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sgurun-gerrit only
Created Revert of [Autofill]Enable mojo AutofillDriver for android_webview.
4 years, 1 month ago (2016-11-22 02:46:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518243002/1
4 years, 1 month ago (2016-11-22 02:47:01 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 02:51:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698