Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2518233003: Wire up the stub native resolver for all libraries in gen_snapshot (Closed)

Created:
4 years, 1 month ago by Cutch
Modified:
4 years, 1 month ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rmacnak in person review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -1 line) Patch
M runtime/bin/gen_snapshot.cc View 1 4 chunks +30 lines, -1 line 0 comments Download
M runtime/include/dart_api.h View 1 1 chunk +24 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 1 chunk +26 lines, -0 lines 2 comments Download

Messages

Total messages: 10 (4 generated)
Cutch
4 years, 1 month ago (2016-11-22 17:20:57 UTC) #4
Cutch
PTAL
4 years, 1 month ago (2016-11-22 18:22:11 UTC) #5
rmacnak
lgtm
4 years, 1 month ago (2016-11-22 18:28:08 UTC) #6
Cutch
Committed patchset #2 (id:20001) manually as 2510646aafac7da6b4e056649eba445a439d558a (presubmit successful).
4 years, 1 month ago (2016-11-22 19:15:31 UTC) #8
siva
lgtm https://codereview.chromium.org/2518233003/diff/20001/runtime/vm/dart_api_impl.cc File runtime/vm/dart_api_impl.cc (right): https://codereview.chromium.org/2518233003/diff/20001/runtime/vm/dart_api_impl.cc#newcode5870 runtime/vm/dart_api_impl.cc:5870: Dart_NativeEntryResolver* resolver) { if (resolver == NULL) { ...
4 years, 1 month ago (2016-11-22 20:48:47 UTC) #9
Cutch
4 years, 1 month ago (2016-11-22 20:52:37 UTC) #10
Message was sent while issue was closed.
Done in follow up https://codereview.chromium.org/2524853002

Powered by Google App Engine
This is Rietveld 408576698