Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2518233002:
Enable setting primary display for 3+ displays (Closed)
DescriptionEnable setting primary display for 3+ displays
BUG=605666
TEST=ash_unittests --gtest_filter=WindowTreeHostManagerTest.SetPrimaryWith*
Committed: https://crrev.com/71948979a39b8f585affccda8535e71b0d381a19
Cr-Commit-Position: refs/heads/master@{#434063}
Patch Set 1 #Patch Set 2 : Rebase and expand tests #
Total comments: 3
Patch Set 3 : Oshima's comment #
Messages
Total messages: 25 (18 generated)
The CQ bit was checked by afakhry@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by afakhry@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
afakhry@chromium.org changed reviewers: + oshima@chromium.org
Oshima-san, please review. Thank you!
Description was changed from ========== Enable setting primary display for 3+ displays BUG=605666 TEST=ash_unittests --gtest_filter=WindowTreeHostManagerTest.SetPrimaryWithThreePlusDisplays* ========== to ========== Enable setting primary display for 3+ displays BUG=605666 TEST=ash_unittests --gtest_filter=WindowTreeHostManagerTest.SetPrimaryWith* ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2518233002/diff/20001/ui/display/manager/disp... File ui/display/manager/display_layout.cc (left): https://codereview.chromium.org/2518233002/diff/20001/ui/display/manager/disp... ui/display/manager/display_layout.cc:218: int64_t id = 0; this should have been std::numeric_limits<int64_t>::min(); https://codereview.chromium.org/2518233002/diff/20001/ui/display/manager/disp... File ui/display/manager/display_layout.cc (right): https://codereview.chromium.org/2518233002/diff/20001/ui/display/manager/disp... ui/display/manager/display_layout.cc:226: } do you need this?
lgtm
https://codereview.chromium.org/2518233002/diff/20001/ui/display/manager/disp... File ui/display/manager/display_layout.cc (right): https://codereview.chromium.org/2518233002/diff/20001/ui/display/manager/disp... ui/display/manager/display_layout.cc:226: } On 2016/11/22 21:47:18, oshima wrote: > do you need this? Reverted to the old way and fixed its bug.
The CQ bit was checked by afakhry@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by afakhry@chromium.org
The CQ bit was checked by afakhry@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org Link to the patchset: https://codereview.chromium.org/2518233002/#ps40001 (title: "Oshima's comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479854276034220,
"parent_rev": "6dca081ec7d00c2b1efd3b63f5a5c0f697f66582", "commit_rev":
"6baee263c6a7ac61ed64b05c66d984f9ad09d9a4"}
Message was sent while issue was closed.
Description was changed from ========== Enable setting primary display for 3+ displays BUG=605666 TEST=ash_unittests --gtest_filter=WindowTreeHostManagerTest.SetPrimaryWith* ========== to ========== Enable setting primary display for 3+ displays BUG=605666 TEST=ash_unittests --gtest_filter=WindowTreeHostManagerTest.SetPrimaryWith* ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Enable setting primary display for 3+ displays BUG=605666 TEST=ash_unittests --gtest_filter=WindowTreeHostManagerTest.SetPrimaryWith* ========== to ========== Enable setting primary display for 3+ displays BUG=605666 TEST=ash_unittests --gtest_filter=WindowTreeHostManagerTest.SetPrimaryWith* Committed: https://crrev.com/71948979a39b8f585affccda8535e71b0d381a19 Cr-Commit-Position: refs/heads/master@{#434063} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/71948979a39b8f585affccda8535e71b0d381a19 Cr-Commit-Position: refs/heads/master@{#434063} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
