Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 251823002: Move didAccessInitialDocument to RenderFrame. (Closed)

Created:
6 years, 8 months ago by Avi (use Gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Charlie Reis, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Move didAccessInitialDocument to RenderFrame. BUG=361761 TEST=no visible change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266637

Patch Set 1 #

Total comments: 5

Patch Set 2 : commentary #

Total comments: 2

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -67 lines) Patch
M content/browser/frame_host/navigation_controller_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 7 chunks +11 lines, -14 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 3 chunks +0 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 chunks +0 lines, -8 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 5 chunks +11 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 4 chunks +11 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Avi (use Gerrit)
https://codereview.chromium.org/251823002/diff/1/content/browser/frame_host/render_frame_host_impl.cc File content/browser/frame_host/render_frame_host_impl.cc (left): https://codereview.chromium.org/251823002/diff/1/content/browser/frame_host/render_frame_host_impl.cc#oldcode442 content/browser/frame_host/render_frame_host_impl.cc:442: render_view_host_->has_accessed_initial_document_ = false; See the comment in WebContentsImpl. https://codereview.chromium.org/251823002/diff/1/content/browser/web_contents/web_contents_impl.cc ...
6 years, 8 months ago (2014-04-25 20:24:43 UTC) #1
Charlie Reis
Great! Thanks for taking care of this. LGTM. https://codereview.chromium.org/251823002/diff/1/content/browser/frame_host/render_frame_host_delegate.h File content/browser/frame_host/render_frame_host_delegate.h (right): https://codereview.chromium.org/251823002/diff/1/content/browser/frame_host/render_frame_host_delegate.h#newcode82 content/browser/frame_host/render_frame_host_delegate.h:82: // ...
6 years, 8 months ago (2014-04-25 20:38:02 UTC) #2
Avi (use Gerrit)
Nasko, IPC, if you will. https://codereview.chromium.org/251823002/diff/1/content/browser/frame_host/render_frame_host_delegate.h File content/browser/frame_host/render_frame_host_delegate.h (right): https://codereview.chromium.org/251823002/diff/1/content/browser/frame_host/render_frame_host_delegate.h#newcode82 content/browser/frame_host/render_frame_host_delegate.h:82: // Another page accessed ...
6 years, 8 months ago (2014-04-25 20:47:16 UTC) #3
nasko
LGTM https://codereview.chromium.org/251823002/diff/20001/content/common/frame_messages.h File content/common/frame_messages.h (right): https://codereview.chromium.org/251823002/diff/20001/content/common/frame_messages.h#newcode575 content/common/frame_messages.h:575: IPC_MESSAGE_ROUTED0(FrameHostMsg_DidAccessInitialDocument) nit: It will be nice for this ...
6 years, 7 months ago (2014-04-28 16:35:57 UTC) #4
Avi (use Gerrit)
https://codereview.chromium.org/251823002/diff/20001/content/common/frame_messages.h File content/common/frame_messages.h (right): https://codereview.chromium.org/251823002/diff/20001/content/common/frame_messages.h#newcode575 content/common/frame_messages.h:575: IPC_MESSAGE_ROUTED0(FrameHostMsg_DidAccessInitialDocument) On 2014/04/28 16:35:57, nasko wrote: > nit: It ...
6 years, 7 months ago (2014-04-28 17:08:24 UTC) #5
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 7 months ago (2014-04-28 17:09:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/251823002/40001
6 years, 7 months ago (2014-04-28 17:09:51 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 17:43:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 17:43:52 UTC) #9
Avi (use Gerrit)
The CQ bit was checked by avi@chromium.org
6 years, 7 months ago (2014-04-28 17:50:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/251823002/40001
6 years, 7 months ago (2014-04-28 17:50:43 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-04-28 19:51:17 UTC) #12
Message was sent while issue was closed. 
Change committed as 266637

Powered by Google App Engine
This is Rietveld 408576698