Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2518193002: MD Settings: change how text wraps for long search engine titles (Closed)

Created:
4 years, 1 month ago by Dan Beam
Modified:
4 years, 1 month ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: change how text wraps for long search engine titles R=dpapad@chromium.org BUG=665211 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/849bd827c5e1d6838c9b3be49785de9a4cfe945b Cr-Commit-Position: refs/heads/master@{#433778}

Patch Set 1 #

Patch Set 2 : dpapad@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M chrome/browser/resources/settings/search_engines_page/search_engine_entry.html View 1 2 chunks +9 lines, -10 lines 0 comments Download
M chrome/test/data/webui/settings/search_engines_page_test.js View 1 chunk +5 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Dan Beam
this is more what i had in mind
4 years, 1 month ago (2016-11-22 01:03:59 UTC) #2
dpapad
lgtm
4 years, 1 month ago (2016-11-22 01:21:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518193002/20001
4 years, 1 month ago (2016-11-22 02:26:14 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 03:48:13 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 03:49:41 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/849bd827c5e1d6838c9b3be49785de9a4cfe945b
Cr-Commit-Position: refs/heads/master@{#433778}

Powered by Google App Engine
This is Rietveld 408576698