Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7527)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.cc

Issue 2518183002: Moved action verbs out of Blink. (Closed)
Patch Set: Added activate action to text field. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/app/strings/content_strings.grd » ('j') | ui/accessibility/ax_enums.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/toolbar_button.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.cc b/chrome/browser/ui/views/toolbar/toolbar_button.cc
index 00e427c500ba6dfb5d3778db8621be4d9013d3e2..08232fd28ff7cd72f5f281c3768f86f7af9069c4 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_button.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_button.cc
@@ -15,11 +15,9 @@
#include "chrome/browser/ui/layout_constants.h"
#include "chrome/browser/ui/views/location_bar/location_bar_view.h"
#include "ui/accessibility/ax_node_data.h"
-#include "ui/base/l10n/l10n_util.h"
#include "ui/base/models/menu_model.h"
#include "ui/display/display.h"
#include "ui/display/screen.h"
-#include "ui/strings/grit/ui_strings.h"
#include "ui/views/controls/button/label_button_border.h"
#include "ui/views/controls/menu/menu_item_view.h"
#include "ui/views/controls/menu/menu_model_adapter.h"
@@ -139,9 +137,10 @@ void ToolbarButton::OnGestureEvent(ui::GestureEvent* event) {
void ToolbarButton::GetAccessibleNodeData(ui::AXNodeData* node_data) {
CustomButton::GetAccessibleNodeData(node_data);
node_data->role = ui::AX_ROLE_BUTTON_DROP_DOWN;
- node_data->AddStringAttribute(
- ui::AX_ATTR_ACTION, l10n_util::GetStringUTF8(IDS_APP_ACCACTION_PRESS));
node_data->AddStateFlag(ui::AX_STATE_HASPOPUP);
+ if (enabled())
+ node_data->AddIntAttribute(ui::AX_ATTR_ACTION,
+ ui::AX_SUPPORTED_ACTION_PRESS);
}
std::unique_ptr<views::LabelButtonBorder> ToolbarButton::CreateDefaultBorder()
« no previous file with comments | « no previous file | content/app/strings/content_strings.grd » ('j') | ui/accessibility/ax_enums.idl » ('J')

Powered by Google App Engine
This is Rietveld 408576698