ui/views/controls/combobox/combobox.cc - Issue 2518183002: Moved action verbs out of Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/combobox/combobox.cc

Issue 2518183002: Moved action verbs out of Blink. (Closed)

Patch Set: Exposes appropriate state and action names when controls are disabled. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/combobox/combobox.cc

diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc

index 852aa5f0fddaa56ee1501cb98c99d538f8f57163..83aab345326780de5c9f092c8fcee3bfc6c384f5 100644

--- a/ui/views/controls/combobox/combobox.cc

+++ b/ui/views/controls/combobox/combobox.cc

@@ -740,6 +740,10 @@ void Combobox::GetAccessibleNodeData(ui::AXNodeData* node_data) {

node_data->role = ui::AX_ROLE_COMBO_BOX;

node_data->SetName(accessible_name_);

node_data->SetValue(model_->GetItemAt(selected_index_));

+ if (enabled()) {

+ node_data->AddIntAttribute(ui::AX_ATTR_ACTION,

+ ui::AX_SUPPORTED_ACTION_OPEN);

+ }

node_data->AddIntAttribute(ui::AX_ATTR_POS_IN_SET, selected_index_);

node_data->AddIntAttribute(ui::AX_ATTR_SET_SIZE, model_->GetItemCount());

}