Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: ui/views/controls/button/custom_button.cc

Issue 2518183002: Moved action verbs out of Blink. (Closed)
Patch Set: Only enabled buttons should expose the press action. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/button/custom_button.cc
diff --git a/ui/views/controls/button/custom_button.cc b/ui/views/controls/button/custom_button.cc
index 4540c1bc52bac0191cad7ba1e2b5204ea6fc6ea5..f1083bec0da4c9dba2ae8082fde776a36f83f2a5 100644
--- a/ui/views/controls/button/custom_button.cc
+++ b/ui/views/controls/button/custom_button.cc
@@ -351,6 +351,9 @@ void CustomButton::GetAccessibleNodeData(ui::AXNodeData* node_data) {
// No additional accessibility node_data set for this button node_data.
break;
}
+ if (state() != STATE_DISABLED)
+ node_data->AddIntAttribute(ui::AX_ATTR_ACTION,
+ ui::AX_SUPPORTED_ACTION_PRESS);
}
void CustomButton::VisibilityChanged(View* starting_from, bool visible) {

Powered by Google App Engine
This is Rietveld 408576698