third_party/WebKit/Source/core/layout/LayoutTableCell.cpp - Issue 2518163002: [css-tables] Fix divide-by-zero resulting from 32-bit overflow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

Issue 2518163002: [css-tables] Fix divide-by-zero resulting from 32-bit overflow (Closed)

Patch Set: update wpt -expected.txt and span-attribute.html but not -expected.txt Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp b/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

index dd75dc792506a9ad42cbe95ba07b312ff959ab06..95d8c81a468ff70ccecf2de483c16f43658b7123 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp

@@ -122,6 +122,8 @@ void LayoutTableCell::willBeRemovedFromTree() {

unsigned LayoutTableCell::parseColSpanFromDOM() const {

ASSERT(node());

+ // TODO(dgrogan): HTMLTableCellElement::colSpan() already clamps to something

+ // smaller than maxColumnIndex; can we just DCHECK here?

if (isHTMLTableCellElement(*node()))

return std::min<unsigned>(toHTMLTableCellElement(*node()).colSpan(),

maxColumnIndex);