Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: third_party/WebKit/Source/core/html/HTMLTableCellElement.h

Issue 2518163002: [css-tables] Fix divide-by-zero resulting from 32-bit overflow (Closed)
Patch Set: update wpt -expected.txt and span-attribute.html but not -expected.txt Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLTableCellElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLTableCellElement.h b/third_party/WebKit/Source/core/html/HTMLTableCellElement.h
index 35564bd8951b2c7f7e2ba962d5f57574eef6ae3d..b5a91c97e5ab77ca19a90695936e6ec68464d402 100644
--- a/third_party/WebKit/Source/core/html/HTMLTableCellElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLTableCellElement.h
@@ -50,6 +50,17 @@ class CORE_EXPORT HTMLTableCellElement final : public HTMLTablePartElement {
const AtomicString& headers() const;
void setRowSpan(unsigned);
+ // Rowspan: match Firefox's limit of 65,534. Edge has a higher limit, at
+ // least 2^17.
+ // Colspan: Firefox uses a limit of 1,000 for colspan and resets the value to
+ // 1.
+ // TODO(dgrogan): Change these to HTML's new specified behavior when
+ // https://github.com/whatwg/html/issues/1198 is resolved.
+ // Public so that HTMLColElement can use maxColSpan. maxRowSpan is only used
+ // by this class but keeping them together seems desirable.
+ static unsigned maxColSpan() { return 8190u; }
+ static unsigned maxRowSpan() { return 65534u; }
+
private:
HTMLTableCellElement(const QualifiedName&, Document&);

Powered by Google App Engine
This is Rietveld 408576698