Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2518133002: [Cronet] Fix NetworkChangeNotifierTest.testNetworkChangeNotifier part 3 (Closed)

Created:
4 years, 1 month ago by pauljensen
Modified:
4 years, 1 month ago
Reviewers:
kapishnikov
CC:
chromium-reviews, cbentzel+watch_chromium.org, mgersh
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Fix NetworkChangeNotifierTest.testNetworkChangeNotifier part 3 Create the socket with AF_INET6 not AF_INET. This is how Android creates sockets: http://androidxref.com/5.1.1_r6/xref/libcore/luni/src/main/java/libcore/io/IoBridge.java#608 This fixes an issue on Lollipop devices where EAFNOSUPPORT is returned. R=kapishnikov CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Committed: https://crrev.com/61096d0768c3fec72d28a1e5dee46b735b54124f Cr-Commit-Position: refs/heads/master@{#433934}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/NetworkChangeNotifierTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
pauljensen
Andrei, PTAL, please CQ when approved. This actually fixes the Lollipop issue :)
4 years, 1 month ago (2016-11-21 20:05:07 UTC) #2
pauljensen
+mgersh to keep Cronet sheriff informed why Lollipop bot is failing
4 years, 1 month ago (2016-11-21 21:14:33 UTC) #4
kapishnikov
lgtm
4 years, 1 month ago (2016-11-22 17:36:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518133002/1
4 years, 1 month ago (2016-11-22 18:40:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 19:05:23 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 19:07:52 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/61096d0768c3fec72d28a1e5dee46b735b54124f
Cr-Commit-Position: refs/heads/master@{#433934}

Powered by Google App Engine
This is Rietveld 408576698