Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Issue 251813008: Remove PDF extension dependencies from grd files (Closed)

Created:
6 years, 7 months ago by raymes
Modified:
6 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, tonyg
Visibility:
Public.

Description

Remove PDF extension dependencies from grd files This removes unnecessary PDF dependencies from component_extension_resources.grd and browser_resources.grd. These particular files get flattened into the HTML and so are not needed in the grd files. BUG=363909 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266844

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/resources/print_preview/previewarea/preview_area.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
raymes
6 years, 7 months ago (2014-04-29 03:11:54 UTC) #1
Lei Zhang
lgtm
6 years, 7 months ago (2014-04-29 05:04:01 UTC) #2
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 7 months ago (2014-04-29 05:23:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/251813008/20001
6 years, 7 months ago (2014-04-29 05:24:03 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 06:04:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 7 months ago (2014-04-29 06:04:29 UTC) #6
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 7 months ago (2014-04-29 06:06:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/251813008/20001
6 years, 7 months ago (2014-04-29 06:06:39 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 06:54:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-29 06:54:35 UTC) #10
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 7 months ago (2014-04-29 06:59:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/251813008/20001
6 years, 7 months ago (2014-04-29 07:00:19 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 11:20:51 UTC) #13
Message was sent while issue was closed.
Change committed as 266844

Powered by Google App Engine
This is Rietveld 408576698