Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 251813006: HTML Imports: Let @async import not block its sibling. (Closed)

Created:
6 years, 7 months ago by Hajime Morrita
Modified:
6 years, 7 months ago
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, dglazkov+blink, adamk+blink_chromium.org, ojan
Visibility:
Public.

Description

HTML Imports: Let @async import not block its sibling. An import with @async attribute did block its following sibling, even though it doesn't block its parent. This is not what it should behave. This change removes that unwanted blocking. Also, the change adds a set of test for @async behavior: The original coverage was too poor. TBR=dglazkov@chromium.org,dominicc@chromium.org TEST=ipmort-async-grandchild.html, import-async-grandchild-not-child.html import-async-previous.html, import-async-previous-async.html import-async-sync-grandchild.html BUG=367371 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -5 lines) Patch
A LayoutTests/http/tests/htmlimports/import-async-grandchild.html View 1 chunk +49 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/htmlimports/import-async-grandchild-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/htmlimports/import-async-grandchild-not-child.html View 1 chunk +35 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/htmlimports/import-async-grandchild-not-child-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/htmlimports/import-async-previous.html View 1 chunk +29 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-async-previous-async.html View 1 chunk +22 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/htmlimports/import-async-previous-async-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + LayoutTests/http/tests/htmlimports/import-async-previous-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/http/tests/htmlimports/import-async-sync-grandchild.html View 1 chunk +31 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/import-async-sync-grandchild-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/resources/async-block-helper.js View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/resources/has-slow-child.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/resources/has-slow-child-async.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/resources/has-slow-script.html View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/resources/has-sync-children.html View 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/htmlimports/resources/not-slow.html View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/imports/HTMLImportStateResolver.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Hajime Morrita
PTAL? This is one of the "ordering bug" that were mentioned in the meeting.
6 years, 7 months ago (2014-04-28 17:57:15 UTC) #1
Hajime Morrita
Apparently we need to another one before landing this :-/
6 years, 7 months ago (2014-04-28 18:53:31 UTC) #2
dglazkov
lgtm
6 years, 7 months ago (2014-04-30 23:24:49 UTC) #3
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 7 months ago (2014-05-01 01:13:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/251813006/1
6 years, 7 months ago (2014-05-01 01:13:39 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 01:20:43 UTC) #6
Message was sent while issue was closed.
Change committed as 173051

Powered by Google App Engine
This is Rietveld 408576698