Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2518063007: Pass QuicInMemoryCache directly instead of using a singleton. (Closed)

Created:
4 years ago by Victor Vasiliev
Modified:
4 years ago
Reviewers:
mef, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass QuicInMemoryCache directly instead of using a singleton. Merge internal change: 139108411 R=rch@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Committed: https://crrev.com/479f0329180254d61297094a500a8cfba22c10d5 Cr-Commit-Position: refs/heads/master@{#435001}

Patch Set 1 #

Patch Set 2 : Pass QuicInMemoryCache directly instead of using a singleton. #

Patch Set 3 : Fix grpc_support #

Patch Set 4 : Fix Cronet and grpc_support #

Patch Set 5 : Fix Cronet compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -290 lines) Patch
M components/cronet/android/test/quic_test_server.cc View 1 2 3 4 4 chunks +8 lines, -6 lines 0 comments Download
M components/grpc_support/test/quic_test_server.cc View 1 2 3 4 chunks +14 lines, -13 lines 0 comments Download
M net/net.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_end_to_end_unittest.cc View 7 chunks +7 lines, -9 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 6 chunks +15 lines, -8 lines 0 comments Download
M net/quic/test_tools/mock_quic_dispatcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/mock_quic_dispatcher.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 14 chunks +35 lines, -25 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 3 chunks +2 lines, -22 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M net/tools/quic/quic_in_memory_cache_test.cc View 10 chunks +26 lines, -41 lines 0 comments Download
M net/tools/quic/quic_server.h View 4 chunks +9 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server.cc View 4 chunks +11 lines, -7 lines 0 comments Download
M net/tools/quic/quic_server_bin.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 5 chunks +13 lines, -5 lines 0 comments Download
M net/tools/quic/quic_simple_dispatcher.h View 3 chunks +8 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_dispatcher.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M net/tools/quic/quic_simple_server.h View 3 chunks +5 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_bin.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_session.h View 3 chunks +6 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 6 chunks +8 lines, -11 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream.h View 3 chunks +6 lines, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_stream.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 14 chunks +26 lines, -26 lines 0 comments Download
M net/tools/quic/quic_simple_server_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
D net/tools/quic/test_tools/quic_in_memory_cache_peer.h View 1 chunk +0 lines, -26 lines 0 comments Download
D net/tools/quic/test_tools/quic_in_memory_cache_peer.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_server.h View 4 chunks +13 lines, -6 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_server.cc View 7 chunks +28 lines, -16 lines 0 comments Download
M net/url_request/url_request_quic_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 33 (26 generated)
Victor Vasiliev
4 years ago (2016-11-23 04:40:22 UTC) #1
Ryan Hamilton
lgtm
4 years ago (2016-11-23 04:44:49 UTC) #4
Victor Vasiliev
Added mef@ for cronet changes.
4 years ago (2016-11-28 23:35:09 UTC) #22
mef
On 2016/11/28 23:35:09, Victor Vasiliev wrote: > Added mef@ for cronet changes. components/cronet and components/grpc_support ...
4 years ago (2016-11-29 15:37:52 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2518063007/80001
4 years ago (2016-11-29 16:01:55 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-11-29 16:07:19 UTC) #31
commit-bot: I haz the power
4 years ago (2016-11-29 16:09:26 UTC) #33
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/479f0329180254d61297094a500a8cfba22c10d5
Cr-Commit-Position: refs/heads/master@{#435001}

Powered by Google App Engine
This is Rietveld 408576698