Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2518063006:
Fixing MediaFling tests (Closed)
|
Created:
4 years, 1 month ago by Zhiqiang Zhang (Slow) Modified:
4 years ago CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org, mustaq Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFixing MediaFling tests
The MediaFling tests started failing due to an issue related to
injecting MouseEvents, which causes the cast button not receiving
touch event, therefore the tests timed out waiting for the Cast
route selection dialog. This CL changes the test util from using
TOOL_TYPE_MOUSE to TOOL_TYPE_FINGER, which fixes the issue.
This CL also re-enables tests that were disabled/marked as flaky
due to this touch event issue.
BUG=623526, 665182
Committed: https://crrev.com/b295326bdf5fd50fd4c782c7dda3024b426a5521
Cr-Commit-Position: refs/heads/master@{#434346}
Patch Set 1 #Patch Set 2 : marking previous @FlakyTest as @RetryOnFailure #
Total comments: 4
Patch Set 3 : addressed nits from mustaq #
Messages
Total messages: 38 (23 generated)
Description was changed from ========== Fixing MediaFling tests The MediaFling tests started failing due to an issue related to injecting MouseEvents, which causes the cast button not receiving touch event, therefore the tests timed out waiting for the Cast route selection dialog. This CL changes the test util from using TOOL_TYPE_MOUSE to TOOL_TYPE_FINGER, which fixes the issue. BUG=623526 ========== to ========== Fixing MediaFling tests The MediaFling tests started failing due to an issue related to injecting MouseEvents, which causes the cast button not receiving touch event, therefore the tests timed out waiting for the Cast route selection dialog. This CL changes the test util from using TOOL_TYPE_MOUSE to TOOL_TYPE_FINGER, which fixes the issue. This CL also re-enables tests that were disabled/marked as flaky due to this touch event issue. BUG=623526 ==========
zqzhang@chromium.org changed reviewers: + avayvod@chromium.org
PTAL The main change is in RouteTestUtils.java. I'm not very sure why TOOL_TYPE_FINGER and TOOL_TYPE_MOUSE make a difference, but the logic inside Android seems different. Or possibly it's a result of any changes by input-dev. Will send them for triaging later.
Good find. LGTM. I think that's probably related to mustaq's work on the mouse and touch events that got a PSA on blink-dev last week. CC him FYI that Android tests relying on mouse events might be broken.
The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Fixing MediaFling tests The MediaFling tests started failing due to an issue related to injecting MouseEvents, which causes the cast button not receiving touch event, therefore the tests timed out waiting for the Cast route selection dialog. This CL changes the test util from using TOOL_TYPE_MOUSE to TOOL_TYPE_FINGER, which fixes the issue. This CL also re-enables tests that were disabled/marked as flaky due to this touch event issue. BUG=623526 ========== to ========== Fixing MediaFling tests The MediaFling tests started failing due to an issue related to injecting MouseEvents, which causes the cast button not receiving touch event, therefore the tests timed out waiting for the Cast route selection dialog. This CL changes the test util from using TOOL_TYPE_MOUSE to TOOL_TYPE_FINGER, which fixes the issue. This CL also re-enables tests that were disabled/marked as flaky due to this touch event issue. BUG=623526, 665182 ==========
The CQ bit was checked by zqzhang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org Link to the patchset: https://codereview.chromium.org/2518063006/#ps20001 (title: "marking previous @FlakyTest as @RetryOnFailure")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by zqzhang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
mustaq@chromium.org changed reviewers: + mustaq@chromium.org
https://codereview.chromium.org/2518063006/diff/20001/chrome/android/javatest... File chrome/android/javatests/src/org/chromium/chrome/browser/media/RouterTestUtils.java (right): https://codereview.chromium.org/2518063006/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/media/RouterTestUtils.java:140: private static void sendMouseAction(Instrumentation instrumentation, int action, long downTime, Curious: why is the test meant for mouse instead of touch? Could you please give us some context re mouse vs touch usage in cast? https://codereview.chromium.org/2518063006/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/media/RouterTestUtils.java:158: * Sends (synchronously) a single mosue click to an absolute screen coordinates. Nit (past typo): "mouse"
Patchset #4 (id:60001) has been deleted
https://codereview.chromium.org/2518063006/diff/20001/chrome/android/javatest... File chrome/android/javatests/src/org/chromium/chrome/browser/media/RouterTestUtils.java (right): https://codereview.chromium.org/2518063006/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/media/RouterTestUtils.java:140: private static void sendMouseAction(Instrumentation instrumentation, int action, long downTime, On 2016/11/23 14:54:06, mustaq wrote: > Curious: why is the test meant for mouse instead of touch? Could you please give > us some context re mouse vs touch usage in cast? Did reply on https://crbug.com/665182 Let's land this fix first and address the touch input issue later. https://codereview.chromium.org/2518063006/diff/20001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/media/RouterTestUtils.java:158: * Sends (synchronously) a single mosue click to an absolute screen coordinates. On 2016/11/23 14:54:06, mustaq wrote: > Nit (past typo): "mouse" Done.
The CQ bit was checked by zqzhang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org Link to the patchset: https://codereview.chromium.org/2518063006/#ps40001 (title: "addressed nits from mustaq")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by zqzhang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by zqzhang@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479999228389190,
"parent_rev": "051bde4c1d4402ed68dfa22f2ef25bcce7e99d0b", "commit_rev":
"9103f3ef34b16ac78dc1660bae29f14263193ed1"}
Message was sent while issue was closed.
Description was changed from ========== Fixing MediaFling tests The MediaFling tests started failing due to an issue related to injecting MouseEvents, which causes the cast button not receiving touch event, therefore the tests timed out waiting for the Cast route selection dialog. This CL changes the test util from using TOOL_TYPE_MOUSE to TOOL_TYPE_FINGER, which fixes the issue. This CL also re-enables tests that were disabled/marked as flaky due to this touch event issue. BUG=623526, 665182 ========== to ========== Fixing MediaFling tests The MediaFling tests started failing due to an issue related to injecting MouseEvents, which causes the cast button not receiving touch event, therefore the tests timed out waiting for the Cast route selection dialog. This CL changes the test util from using TOOL_TYPE_MOUSE to TOOL_TYPE_FINGER, which fixes the issue. This CL also re-enables tests that were disabled/marked as flaky due to this touch event issue. BUG=623526, 665182 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Fixing MediaFling tests The MediaFling tests started failing due to an issue related to injecting MouseEvents, which causes the cast button not receiving touch event, therefore the tests timed out waiting for the Cast route selection dialog. This CL changes the test util from using TOOL_TYPE_MOUSE to TOOL_TYPE_FINGER, which fixes the issue. This CL also re-enables tests that were disabled/marked as flaky due to this touch event issue. BUG=623526, 665182 ========== to ========== Fixing MediaFling tests The MediaFling tests started failing due to an issue related to injecting MouseEvents, which causes the cast button not receiving touch event, therefore the tests timed out waiting for the Cast route selection dialog. This CL changes the test util from using TOOL_TYPE_MOUSE to TOOL_TYPE_FINGER, which fixes the issue. This CL also re-enables tests that were disabled/marked as flaky due to this touch event issue. BUG=623526, 665182 Committed: https://crrev.com/b295326bdf5fd50fd4c782c7dda3024b426a5521 Cr-Commit-Position: refs/heads/master@{#434346} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b295326bdf5fd50fd4c782c7dda3024b426a5521 Cr-Commit-Position: refs/heads/master@{#434346} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
