Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6502)

Unified Diff: chrome/browser/media_galleries/fileapi/picasa_data_provider.h

Issue 2518053002: Always delete media galleries FilePathWatchers on the FILE thread. (Closed)
Patch Set: fix build error Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/fileapi/picasa_data_provider.h
diff --git a/chrome/browser/media_galleries/fileapi/picasa_data_provider.h b/chrome/browser/media_galleries/fileapi/picasa_data_provider.h
index d631fbbafd1fa748460ec2c34d493970aa9f0308..798d91d2324db313e2a7931fec457768747a8857 100644
--- a/chrome/browser/media_galleries/fileapi/picasa_data_provider.h
+++ b/chrome/browser/media_galleries/fileapi/picasa_data_provider.h
@@ -18,6 +18,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/time/time.h"
+#include "chrome/browser/media_galleries/fileapi/file_path_watcher_util.h"
#include "chrome/common/media_galleries/picasa_types.h"
namespace picasa {
@@ -67,7 +68,7 @@ class PicasaDataProvider {
// Called when the FilePathWatcher for Picasa's temp directory has started.
virtual void OnTempDirWatchStarted(
- std::unique_ptr<base::FilePathWatcher> temp_dir_watcher);
+ MediaFilePathWatcherUniquePtr temp_dir_watcher);
// Called when Picasa's temp directory has changed. Virtual for testing.
virtual void OnTempDirChanged(const base::FilePath& temp_dir_path,
@@ -109,7 +110,7 @@ class PicasaDataProvider {
// We watch the temp dir, as we can't detect database file modifications on
// Mac, but we are able to detect creation and deletion of temporary files.
- std::unique_ptr<base::FilePathWatcher> temp_dir_watcher_;
+ MediaFilePathWatcherUniquePtr temp_dir_watcher_;
base::WeakPtrFactory<PicasaDataProvider> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698