components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h - Issue 2518033002: [Bookmark suggestions] Clean-up in the api: switch const* to const&

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h

Issue 2518033002: [Bookmark suggestions] Clean-up in the api: switch const* to const& (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h

diff --git a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h

index c1301cb386d73c7354469423e5d1c29b00f4ed13..5de4616d9c53c735598103b1c3f847d4cc5b99a1 100644

--- a/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h

+++ b/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h

@@ -91,7 +91,7 @@ class BookmarkSuggestionsProvider : public ContentSuggestionsProvider,

bookmarks::BookmarkModel* model,

const std::set<GURL>& removed_urls) override {}

- void ConvertBookmark(const bookmarks::BookmarkNode* bookmark,

+ void ConvertBookmark(const bookmarks::BookmarkNode& bookmark,

std::vector<ContentSuggestion>* suggestions);

// The actual method to fetch bookmarks - follows each call to FetchBookmarks