Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: components/ntp_snippets/bookmarks/bookmark_suggestions_provider.h

Issue 2518033002: [Bookmark suggestions] Clean-up in the api: switch const* to const& (Closed)
Patch Set: Rebase fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_NTP_SNIPPETS_BOOKMARKS_BOOKMARK_SUGGESTIONS_PROVIDER_H_ 5 #ifndef COMPONENTS_NTP_SNIPPETS_BOOKMARKS_BOOKMARK_SUGGESTIONS_PROVIDER_H_
6 #define COMPONENTS_NTP_SNIPPETS_BOOKMARKS_BOOKMARK_SUGGESTIONS_PROVIDER_H_ 6 #define COMPONENTS_NTP_SNIPPETS_BOOKMARKS_BOOKMARK_SUGGESTIONS_PROVIDER_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 void BookmarkNodeFaviconChanged( 80 void BookmarkNodeFaviconChanged(
81 bookmarks::BookmarkModel* model, 81 bookmarks::BookmarkModel* model,
82 const bookmarks::BookmarkNode* node) override {} 82 const bookmarks::BookmarkNode* node) override {}
83 void BookmarkNodeChildrenReordered( 83 void BookmarkNodeChildrenReordered(
84 bookmarks::BookmarkModel* model, 84 bookmarks::BookmarkModel* model,
85 const bookmarks::BookmarkNode* node) override {} 85 const bookmarks::BookmarkNode* node) override {}
86 void BookmarkAllUserNodesRemoved( 86 void BookmarkAllUserNodesRemoved(
87 bookmarks::BookmarkModel* model, 87 bookmarks::BookmarkModel* model,
88 const std::set<GURL>& removed_urls) override {} 88 const std::set<GURL>& removed_urls) override {}
89 89
90 void ConvertBookmark(const bookmarks::BookmarkNode* bookmark, 90 void ConvertBookmark(const bookmarks::BookmarkNode& bookmark,
91 std::vector<ContentSuggestion>* suggestions); 91 std::vector<ContentSuggestion>* suggestions);
92 92
93 // The actual method to fetch bookmarks - follows each call to FetchBookmarks 93 // The actual method to fetch bookmarks - follows each call to FetchBookmarks
94 // but not sooner than the BookmarkModel gets loaded. 94 // but not sooner than the BookmarkModel gets loaded.
95 void FetchBookmarksInternal(); 95 void FetchBookmarksInternal();
96 96
97 // Queries the BookmarkModel for recently visited bookmarks and pushes the 97 // Queries the BookmarkModel for recently visited bookmarks and pushes the
98 // results to the ContentSuggestionService. The actual fetching does not 98 // results to the ContentSuggestionService. The actual fetching does not
99 // happen before the Bookmark model gets loaded. 99 // happen before the Bookmark model gets loaded.
100 void FetchBookmarks(); 100 void FetchBookmarks();
(...skipping 13 matching lines...) Expand all
114 // deciding which bookmarks to suggest. Should we also consider visits on 114 // deciding which bookmarks to suggest. Should we also consider visits on
115 // desktop platforms? 115 // desktop platforms?
116 bool consider_bookmark_visits_from_desktop_; 116 bool consider_bookmark_visits_from_desktop_;
117 117
118 DISALLOW_COPY_AND_ASSIGN(BookmarkSuggestionsProvider); 118 DISALLOW_COPY_AND_ASSIGN(BookmarkSuggestionsProvider);
119 }; 119 };
120 120
121 } // namespace ntp_snippets 121 } // namespace ntp_snippets
122 122
123 #endif // COMPONENTS_NTP_SNIPPETS_BOOKMARKS_BOOKMARK_SUGGESTIONS_PROVIDER_H_ 123 #endif // COMPONENTS_NTP_SNIPPETS_BOOKMARKS_BOOKMARK_SUGGESTIONS_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698