Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2518023002: Update third_party/pkg/kernel version (Closed)

Created:
4 years, 1 month ago by asgerf
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update third_party/pkg/kernel version This CL also updates the use of kernel in dart2js, and updates the VM/kernel status files. This is a preliminary step to moving kernel into the SDK repository. BUG= R=het@google.com, johnniwinther@google.com, kmillikin@google.com, sigmund@google.com, vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/5d66d0e5dc32ce06641f360876361a07de821997 Reverted: https://github.com/dart-lang/sdk/commit/d69e048d600468f4a4fe112cb7a750f79e5d9c69 Committed: https://github.com/dart-lang/sdk/commit/fbb698393d65a32fa34041323a44c53338994fd7

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebase and fix kernel revision #

Patch Set 3 : Update status file after rebase #

Patch Set 4 : Merge again again and update more test expectations #

Patch Set 5 : Revert + Unrevert #

Patch Set 6 : Fix type annotation in dart2js and update status to match buildbot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -51 lines) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/kernel.dart View 1 2 3 4 5 5 chunks +27 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 2 3 13 chunks +20 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/kernel/unresolved.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M tests/co19/co19-kernel.status View 1 2 3 4 5 5 chunks +15 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 2 3 4 5 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
asgerf
https://codereview.chromium.org/2518023002/diff/1/tests/co19/co19-kernel.status File tests/co19/co19-kernel.status (right): https://codereview.chromium.org/2518023002/diff/1/tests/co19/co19-kernel.status#newcode335 tests/co19/co19-kernel.status:335: LibTest/core/RegExp/stringMatch_A01_t01: RuntimeError These are caused by the fact that ...
4 years, 1 month ago (2016-11-21 15:10:14 UTC) #5
Siggi Cherem (dart-lang)
lgtm
4 years, 1 month ago (2016-11-21 16:12:41 UTC) #6
Vyacheslav Egorov (Google)
LGTM
4 years, 1 month ago (2016-11-21 16:17:26 UTC) #7
Kevin Millikin (Google)
lgtm
4 years, 1 month ago (2016-11-21 17:48:06 UTC) #8
Harry Terkelsen
lgtm
4 years, 1 month ago (2016-11-21 17:51:10 UTC) #9
Johnni Winther
lgtm
4 years, 1 month ago (2016-11-22 09:15:15 UTC) #10
asgerf
Committed patchset #4 (id:60001) manually as 5d66d0e5dc32ce06641f360876361a07de821997 (presubmit successful).
4 years, 1 month ago (2016-11-22 12:42:20 UTC) #12
asgerf
4 years, 1 month ago (2016-11-22 14:22:27 UTC) #16
Message was sent while issue was closed.
Committed patchset #6 (id:100001) manually as
fbb698393d65a32fa34041323a44c53338994fd7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698