[ignition] Add a reverse bytecode iterator

[ignition] Add a reverse bytecode iterator

This pre-calculates and stores a vector of bytecode offsets, and then allows
one to iterate over it backwards. This could probably be adapted to a
bidirectional/random access iterator if we wanted to, but for now reverse
is all we need.

Committed: https://crrev.com/f91178e8230522abdfbc9aeb089cc237a323baa8
Cr-Commit-Position: refs/heads/master@{#41153}

[Leszek Swirski, 2016-11-21 14:08:03]

The CQ bit was checked by leszeks@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 14:08:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Leszek Swirski, 2016-11-21 14:12:44]

leszeks@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[Leszek Swirski, 2016-11-21 14:12:45]

Hi Ross,
Here's the reverse iterator itself.

[commit-bot: I haz the power, 2016-11-21 14:49:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 14:49:04]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-11-21 15:06:59]

lgtm

https://codereview.chromium.org/2518003002/diff/1/src/interpreter/bytecode-ar...
File src/interpreter/bytecode-array-reverse-iterator.h (right):

https://codereview.chromium.org/2518003002/diff/1/src/interpreter/bytecode-ar...
src/interpreter/bytecode-array-reverse-iterator.h:16: class V8_EXPORT_PRIVATE
BytecodeArrayReverseIterator
final

[Leszek Swirski, 2016-11-21 16:48:49]

The CQ bit was checked by leszeks@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 16:49:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 17:13:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 17:13:56]

Dry run: This issue passed the CQ dry run.

[Leszek Swirski, 2016-11-21 17:16:31]

The CQ bit was checked by leszeks@chromium.org

[Leszek Swirski, 2016-11-21 17:16:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2518003002/#ps20001
(title: "Make class final")

[commit-bot: I haz the power, 2016-11-21 17:16:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 17:16:36]

This CL has an open dependency (Issue 2519923002 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Leszek Swirski, 2016-11-21 17:18:44]

The CQ bit was checked by leszeks@chromium.org

[commit-bot: I haz the power, 2016-11-21 17:18:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 17:20:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479748724691210,
"parent_rev": "86222ea9d7bffd3d441e159a8b955fb39c771b3f", "commit_rev":
"a1e1304dd1b7b25a335c8082f16d185584a3543c"}

[commit-bot: I haz the power, 2016-11-21 17:20:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-21 17:21:21]

Description was changed from

==========
[ignition] Add a reverse bytecode iterator

This pre-calculates and stores a vector of bytecode offsets, and then allows
one to iterate over it backwards. This could probably be adapted to a
bidirectional/random access iterator if we wanted to, but for now reverse
is all we need.
==========

to

==========
[ignition] Add a reverse bytecode iterator

This pre-calculates and stores a vector of bytecode offsets, and then allows
one to iterate over it backwards. This could probably be adapted to a
bidirectional/random access iterator if we wanted to, but for now reverse
is all we need.

Committed: https://crrev.com/f91178e8230522abdfbc9aeb089cc237a323baa8
Cr-Commit-Position: refs/heads/master@{#41153}
==========

[commit-bot: I haz the power, 2016-11-21 17:21:21]

Patchset 2 (id:??) landed as
https://crrev.com/f91178e8230522abdfbc9aeb089cc237a323baa8
Cr-Commit-Position: refs/heads/master@{#41153}