Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: components/password_manager/core/browser/credential_manager_pending_request_task.h

Issue 2517993004: Refactor CredentialManagerImpl::Get. It should use PasswordStore::GetLogins(). (Closed)
Patch Set: use set Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/credential_manager_pending_request_task.h
diff --git a/components/password_manager/core/browser/credential_manager_pending_request_task.h b/components/password_manager/core/browser/credential_manager_pending_request_task.h
index 00ad0bcc72ef2b047ee267fcc5de0295e3f7751f..b29994a9dd23e9805a429aa1887609fcdd55662b 100644
--- a/components/password_manager/core/browser/credential_manager_pending_request_task.h
+++ b/components/password_manager/core/browser/credential_manager_pending_request_task.h
@@ -37,9 +37,6 @@ class CredentialManagerPendingRequestTaskDelegate {
// Retrieves the current page origin.
virtual GURL GetOrigin() const = 0;
- // Retrieves a synthetic PasswordForm for the current page origin.
- virtual PasswordStore::FormDigest GetSynthesizedFormForOrigin() const = 0;
-
// Returns the PasswordManagerClient.
virtual PasswordManagerClient* client() const = 0;
@@ -60,10 +57,8 @@ class CredentialManagerPendingRequestTask : public PasswordStoreConsumer {
CredentialManagerPendingRequestTaskDelegate* delegate,
const SendCredentialCallback& callback,
bool request_zero_click_only,
- const GURL& request_origin,
bool include_passwords,
- const std::vector<GURL>& request_federations,
- const std::vector<std::string>& affiliated_realms);
+ const std::vector<GURL>& request_federations);
~CredentialManagerPendingRequestTask() override;
SendCredentialCallback send_callback() const { return send_callback_; }
@@ -80,7 +75,6 @@ class CredentialManagerPendingRequestTask : public PasswordStoreConsumer {
const GURL origin_;
const bool include_passwords_;
std::set<std::string> federations_;
- std::set<std::string> affiliated_realms_;
DISALLOW_COPY_AND_ASSIGN(CredentialManagerPendingRequestTask);
};

Powered by Google App Engine
This is Rietveld 408576698