Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: components/password_manager/content/browser/credential_manager_impl.h

Issue 2517993004: Refactor CredentialManagerImpl::Get. It should use PasswordStore::GetLogins(). (Closed)
Patch Set: use set Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/content/browser/credential_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/content/browser/credential_manager_impl.h
diff --git a/components/password_manager/content/browser/credential_manager_impl.h b/components/password_manager/content/browser/credential_manager_impl.h
index 3d1d3fcd7702e43f5db5d6ccfd9d763f1a4ad22a..3b3f5cd97ba6db38bb440c68a73e98bf3bcfbb8f 100644
--- a/components/password_manager/content/browser/credential_manager_impl.h
+++ b/components/password_manager/content/browser/credential_manager_impl.h
@@ -67,7 +67,6 @@ class CredentialManagerImpl
void SendPasswordForm(const SendCredentialCallback& send_callback,
const autofill::PasswordForm* form) override;
PasswordManagerClient* client() const override;
- PasswordStore::FormDigest GetSynthesizedFormForOrigin() const override;
// CredentialManagerPendingSignedOutTaskDelegate:
PasswordStore* GetPasswordStore() override;
@@ -76,20 +75,14 @@ class CredentialManagerImpl
// CredentialManagerPasswordFormManagerDelegate:
void OnProvisionalSaveComplete() override;
+ // Returns FormDigest for the current URL.
+ PasswordStore::FormDigest GetSynthesizedFormForOrigin() const;
+
private:
// Returns the driver for the current main frame.
// Virtual for testing.
virtual base::WeakPtr<PasswordManagerDriver> GetDriver();
- // Schedules a CredentiaManagerPendingRequestTask (during
- // |OnRequestCredential()|) after the PasswordStore's AffiliationMatchHelper
- // grabs a list of realms related to the current web origin.
- void ScheduleRequestTask(const GetCallback& callback,
- bool zero_click_only,
- bool include_passwords,
- const std::vector<GURL>& federations,
- const std::vector<std::string>& android_realms);
-
PasswordManagerClient* client_;
std::unique_ptr<CredentialManagerPasswordFormManager> form_manager_;
« no previous file with comments | « no previous file | components/password_manager/content/browser/credential_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698