components/password_manager/content/browser/credential_manager_impl_unittest.cc - Issue 2517993004: Refactor CredentialManagerImpl::Get. It should use PasswordStore::GetLogins().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/credential_manager_impl_unittest.cc

Issue 2517993004: Refactor CredentialManagerImpl::Get. It should use PasswordStore::GetLogins(). (Closed)

Patch Set: iOS Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/credential_manager_impl.cc ('k') | components/password_manager/core/browser/credential_manager_pending_request_task.h » ('j') | components/password_manager/core/browser/credential_manager_pending_request_task.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/credential_manager_impl_unittest.cc

diff --git a/components/password_manager/content/browser/credential_manager_impl_unittest.cc b/components/password_manager/content/browser/credential_manager_impl_unittest.cc

index a3b064cd34cd5e0b9db83ef0d00972561a1d4ace..e9337abff99c746f94348e47b38bf77d722948d2 100644

--- a/components/password_manager/content/browser/credential_manager_impl_unittest.cc

+++ b/components/password_manager/content/browser/credential_manager_impl_unittest.cc

@@ -570,7 +570,6 @@ TEST_F(CredentialManagerImplTest, CredentialManagerGetOverwriteZeroClick) {

form_.skip_zero_click = true;

form_.username_element = base::ASCIIToUTF16("username-element");

form_.password_element = base::ASCIIToUTF16("password-element");

- form_.signon_realm = "this is a realm";

vabr (Chromium) 2016/11/23 08:57:56 I'm curious why this needed to be removed. If I re

vasilii 2016/11/23 09:40:54 |form_| has already correct origin and signon_real

form_.origin = GURL("https://example.com/old_form.html");

store_->AddLogin(form_);

RunAllPendingTasks();