Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2517993003: Convert one more CFI blacklist entry into DISABLE_CFI_PERF attribute. (Closed)

Created:
4 years, 1 month ago by krasin1
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert one more CFI blacklist entry into DISABLE_CFI_PERF attribute. This one is tricky as it broke Chrome OS build last time. The line now moved below the template parameter, and that should work. The primary problem here is that Chrome OS lacks a trybot here, so it's impossible to know in advance, if the change is going to break it. BUG=641536 TBR=eae Committed: https://crrev.com/565ff1e9c4a5bcda8db37bdd8365a7eee9f3c029 Cr-Commit-Position: refs/heads/master@{#433684}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/platform/PODIntervalTree.h View 1 chunk +2 lines, -1 line 0 comments Download
M tools/cfi/blacklist.txt View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517993003/1
4 years, 1 month ago (2016-11-21 22:52:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 23:14:46 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 23:18:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/565ff1e9c4a5bcda8db37bdd8365a7eee9f3c029
Cr-Commit-Position: refs/heads/master@{#433684}

Powered by Google App Engine
This is Rietveld 408576698