Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2517993002: Scope cleanup: remove unneeded params. (Closed)

Created:
4 years ago by marja
Modified:
4 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Scope cleanup: remove unneeded params. BUG= Committed: https://crrev.com/0c92a6eb2b9cdd36ba5ad1f7e5ba7c6b943e8b48 Cr-Commit-Position: refs/heads/master@{#41145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -19 lines) Patch
M src/ast/scopes.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ast/scopes.cc View 7 chunks +13 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Toon Verwaest
Nice! lgtm. A slightly better description may be useful ;)
4 years ago (2016-11-21 13:42:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517993002/1
4 years ago (2016-11-21 13:44:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517993002/1
4 years ago (2016-11-21 14:15:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-21 14:24:08 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-21 14:24:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c92a6eb2b9cdd36ba5ad1f7e5ba7c6b943e8b48
Cr-Commit-Position: refs/heads/master@{#41145}

Powered by Google App Engine
This is Rietveld 408576698