Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 2517953007: Add python-google.gni and valgrind.gni to list all files. (Closed)

Created:
2 years, 10 months ago by ehmaldonado_chromium
Modified:
2 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add python-google.gni and valgrind.gni to list all files under tools/python/google and tools/valgrind respectively. This will be used to include them as run-time dependencies when the tests are run with memcheck on swarming. BUG=chromium:497757 Committed: https://crrev.com/6159ad67fdd0905753d6d02c2e75ec743ae5489a Cr-Commit-Position: refs/heads/master@{#434250}

Patch Set 1 #

Patch Set 2 : Add valgrind.gni #

Total comments: 1

Patch Set 3 : python_google -> python_google_files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
A tools/python/google/python-google.gni View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A tools/valgrind/valgrind.gni View 1 1 chunk +64 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
ehmaldonado_chromium
2 years, 10 months ago (2016-11-23 17:36:33 UTC) #4
scottmg
lgtm https://codereview.chromium.org/2517953007/diff/60001/tools/python/google/python-google.gni File tools/python/google/python-google.gni (right): https://codereview.chromium.org/2517953007/diff/60001/tools/python/google/python-google.gni#newcode5 tools/python/google/python-google.gni:5: python_google = [ python_google_files or _sources or something.
2 years, 10 months ago (2016-11-23 18:08:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517953007/80001
2 years, 10 months ago (2016-11-23 18:16:22 UTC) #10
kjellander_chromium
lgtm
2 years, 10 months ago (2016-11-23 20:03:37 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:80001)
2 years, 10 months ago (2016-11-23 21:23:40 UTC) #14
commit-bot: I haz the power
2 years, 10 months ago (2016-11-23 21:25:21 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6159ad67fdd0905753d6d02c2e75ec743ae5489a
Cr-Commit-Position: refs/heads/master@{#434250}

Powered by Google App Engine
This is Rietveld 408576698