Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2517953006: [ash-md] Adds Wi-Fi network status indicators in system menu (Closed)

Created:
4 years, 1 month ago by varkha
Modified:
4 years ago
Reviewers:
tdanderson
CC:
chromium-reviews, kalyank, stevenjb+watch_chromium.org, oshima+watch_chromium.org, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Adds Wi-Fi network status indicators in system menu BUG=663129 Test=Connect to a Wi-Fi network. Verify that connected network has "Connected" indicator. Verify that connected network appears at the top of the list. Committed: https://crrev.com/bd890d24dd4bb15a15e891d4fdb273dc330d7f2a Cr-Commit-Position: refs/heads/master@{#434283}

Patch Set 1 #

Total comments: 5

Patch Set 2 : [ash-md] Adds Wi-Fi network status indicators in system menu #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -13 lines) Patch
M ash/common/system/chromeos/network/network_info.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/common/system/chromeos/network/network_info.cc View 1 chunk +7 lines, -1 line 0 comments Download
M ash/common/system/chromeos/network/network_list_md.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M ash/common/system/chromeos/network/network_state_list_detailed_view.cc View 1 3 chunks +44 lines, -9 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
varkha
tdanderson@, can you please take the first look? This has some code duplication that I ...
4 years, 1 month ago (2016-11-23 00:22:11 UTC) #4
tdanderson
LGTM. If the code duplication you're talking about is where the two-line text gets set ...
4 years, 1 month ago (2016-11-23 02:35:35 UTC) #7
varkha
> avoid refactoring that for the time being Makes sense. Thanks! https://codereview.chromium.org/2517953006/diff/1/ash/common/system/chromeos/network/network_state_list_detailed_view.cc File ash/common/system/chromeos/network/network_state_list_detailed_view.cc (right): ...
4 years ago (2016-11-23 20:26:56 UTC) #8
tdanderson
https://codereview.chromium.org/2517953006/diff/1/ash/common/system/chromeos/network/network_state_list_detailed_view.cc File ash/common/system/chromeos/network/network_state_list_detailed_view.cc (right): https://codereview.chromium.org/2517953006/diff/1/ash/common/system/chromeos/network/network_state_list_detailed_view.cc#newcode1014 ash/common/system/chromeos/network/network_state_list_detailed_view.cc:1014: DCHECK(!container->has_children()); On 2016/11/23 20:26:55, varkha wrote: > On 2016/11/23 ...
4 years ago (2016-11-23 21:36:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2517953006/20001
4 years ago (2016-11-23 22:39:36 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-23 23:48:54 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-23 23:52:51 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd890d24dd4bb15a15e891d4fdb273dc330d7f2a
Cr-Commit-Position: refs/heads/master@{#434283}

Powered by Google App Engine
This is Rietveld 408576698